Skip to content
This repository has been archived by the owner on Apr 7, 2020. It is now read-only.

Github dependency #23

Open
umdstu opened this issue May 24, 2018 · 3 comments
Open

Github dependency #23

umdstu opened this issue May 24, 2018 · 3 comments

Comments

@umdstu
Copy link

umdstu commented May 24, 2018

Is there still a reason this package needs to be dependent on github:

"leaflet-draw": "git://github.com/michaelguild13/Leaflet.draw.git#master",

instead of Leaflet.Draw since it's in NPM ?

@nmccready
Copy link
Contributor

Probably not, feel free to submit a PR.

@umdstu
Copy link
Author

umdstu commented May 28, 2018

Seems simple enough, but since this is currently pointing to something several years old (and several hundred commits behind /Leaflet/Leaflet.draw, what are the chances of this working with the 'current' version of Leaflet.draw?

@nmccready
Copy link
Contributor

I don't really have any idea. I don't really have time to commit to that right now. I would assume it would not.

Also the repo git://github.com/michaelguild13/Leaflet.draw.git#master is a fork by @michaelguild13 which did not seem to be published to NPM . The reason for pointing to that fork; was at the time he was the only one that supported touch screens correctly. I would hope that this has been resolved by now .

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants