This repository was archived by the owner on May 29, 2019. It is now read-only.
feat(position): add 'positionElementAt' method #6339
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm creating a context menu directive, and was wanting to use the same positioning logic as all of the bootstrap elements we use. |
farooqu
force-pushed
the
position-elementAt
branch
2 times, most recently
from
94b766b to
8481323
Compare
Add a method to position an element at client x/y coordinates. Using code from the positionElements method, which has been refactored into a positionElement method with both positionElementAt and positionElements use.
farooqu
force-pushed
the
position-elementAt
branch
from
8481323 to
c761800
Compare
|
I'm not sure I see the value of this in the library itself - it doesn't appear like something anything in UI Bootstrap would use. In addition, this appears to be wholly independent code - one could just create a wrapper around the UI Bootstrap $uibPosition service and add this method to the wrapper, or decorate it with $provide.decorator. There are lots of ways to place it in one's application that doesn't require shipping code that is unused for most users. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a method to position an element at client x/y coordinates. Using
code from the positionElements method, which has been refactored into a
positionElement method with both positionElementAt and positionElements
use.