This repository was archived by the owner on Nov 30, 2018. It is now read-only.
fix(map-loader): change includeScript to place maps api script tag to head element instead of body #1899
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… head element instead of body Placing the script tag in document body causes the Google Maps API to be included multiple times when document is stored using the History API and then later retrieved (e.g. when using Turbolinks.js). Placing the script tag inside head element solves this problem, ensuring the Google Maps API is loaded only once.
lkol
changed the title
Contributor
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Placing the script tag in document body causes the Google Maps API to be included multiple times
when document is stored using the History API and then later retrieved (e.g. when using
Turbolinks.js). Placing the script tag inside head element solves this problem, ensuring the Google
Maps API is loaded only once.