Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variant of ResetPasswordConfirm that validates a token #45

Closed
bctiemann opened this issue Apr 17, 2019 · 5 comments
Closed

Variant of ResetPasswordConfirm that validates a token #45

bctiemann opened this issue Apr 17, 2019 · 5 comments

Comments

@bctiemann
Copy link

Idea for an enhancement: it would be great to have an endpoint where a token could be checked for validity, without submitting a new password.

This would fit into the SPA architecture by allowing the app to present an error page instead of a password-reset form if the page is loaded with an invalid token. Otherwise the user has to try submitting the password change request before getting a rejection.

This might be done with an additional param on ResetPasswordConfirm, or a separate view altogether.

@anx-ckreuzberger
Copy link
Contributor

This would definately improve UX!

If anyone is up, I'll accept a merge request for this. It basically only means to adapt the code here to allow the token to be verified without a password:
https://github.com/anx-ckreuzberger/django-rest-passwordreset/blob/7118d430d4b21f78a23530c88a33390c9b6a4f95/django_rest_passwordreset/views.py#L26-L47

@anx-ckreuzberger
Copy link
Contributor

Thanks to the help of @Hall-Erik and MR #60 we just released this feature on PyPi in version 1.1.0rc3.

You should be able install and test it using

pip install django-rest-passwordreset==1.1.0rc3

@bctiemann
Copy link
Author

Looks/works great. Thank you!

@rafaelcascalho
Copy link

Hey guys! Is this issue still open?

@ghost ghost self-assigned this Feb 7, 2020
@nezhar
Copy link
Member

nezhar commented Oct 14, 2021

This has already been released with 1.1.0

@nezhar nezhar closed this as completed Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants