Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node: no handle for 'unhandledRejection' #49

Closed
mijay opened this issue May 8, 2017 · 2 comments
Closed

Node: no handle for 'unhandledRejection' #49

mijay opened this issue May 8, 2017 · 2 comments

Comments

@mijay
Copy link

mijay commented May 8, 2017

While worker.node/slave.js subscribes and nicely handles 'uncaughtException' event, similar 'unhandledRejection' is not handled there. And hence, promise-based workloads don't have the same "last resort" error catching as callback-based.
@andywer
Copy link
Owner

andywer commented May 8, 2017

Hey @mijay.

This is a good point. Wanna open a PR?

@mijay mijay mentioned this issue May 8, 2017
Merged
@mijay
Copy link
Author

mijay commented May 8, 2017

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mijay @andywer