Skip to content

This PR improves rendering performance #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

This PR improves rendering performance #84

wants to merge 3 commits into from

Conversation

dirisujesse
Copy link

  1. I extracted the the Selectable and Normal variants of the returned RichText into widget classes.
  2. I associated keys to the returned RichText to help the engine identify them and mitigate against unneeded rebuilds.
  3. I changed the name of the variable async to parseAsynchronously

@dirisujesse
FIrst commit
c672ab7 
- Separates selectable/normal options to widgets
- Refactors conditionals into early exit/guard pattern for readability
- Adds keys to RichText widgets to mitigate rebuilds

Signed-off-by: Jesse Dirisu <dirisujesse@gmail.com>
@dirisujesse
Further refactor
0aee1f3 
Signed-off-by: Jesse Dirisu <dirisujesse@gmail.com>
@dirisujesse
revert pubspec.yaml to original form
f92bd97 
Signed-off-by: Jesse Dirisu <dirisujesse@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dirisujesse @jogboms