Skip to content

Commit 0cb0934

Browse files
author
Tyler King
authored
Feature/php 8 support (gnikyt#664)
* Test PHP 8 support for Actions * Drop older Laravel versions * Exclude Laravel 7 from PHP 8 since Laravel 7 required ^7.2 * Use Laravel 8.22 as it supports PHP 8 and has no security reports * Fix version 8.0 to 8.22 for Actions
1 parent d351c39 commit 0cb0934

File tree

3 files changed

+10
-11
lines changed

3 files changed

+10
-11
lines changed

.github/workflows/ci.yml

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -13,16 +13,15 @@ jobs:
1313
- '7.2'
1414
- '7.3'
1515
- '7.4'
16+
- '8.0'
1617
laravel:
17-
- '5.8'
18-
- '6.0'
1918
- '7.0'
20-
- '8.0'
19+
- '8.22'
2120
exclude:
22-
- php: '7.4'
23-
laravel: '5.8'
2421
- php: '7.2'
25-
laravel: '8.0'
22+
laravel: '8.22'
23+
- php: '8.0'
24+
laravel: '7.0'
2625

2726
name: PHP ${{ matrix.php }} / Laravel ${{ matrix.laravel }}
2827

@@ -41,7 +40,7 @@ jobs:
4140
run: composer validate --strict
4241

4342
- name: Install Laravel legacy factories support
44-
if: matrix.laravel == '8.0'
43+
if: matrix.laravel == '8.22'
4544
run: composer require "laravel/legacy-factories:^1.0" --no-interaction --no-update
4645

4746
- name: Install Laravel and Orchestra Testbench
@@ -62,7 +61,7 @@ jobs:
6261
run: vendor/bin/phpunit
6362

6463
- name: Upload coverage results
65-
if: matrix.php == '7.4' && matrix.laravel == '8.0'
64+
if: matrix.php == '8.22' && matrix.laravel == '8.22'
6665
env:
6766
COVERALLS_REPO_TOKEN: ${{ secrets.GITHUB_TOKEN }}
6867
run: |

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
----
99

10-
A full-featured Laravel package for aiding in Shopify App development, similar to `shopify_app` for Rails. Works for Laravel 5.6+
10+
A full-featured Laravel package for aiding in Shopify App development, similar to `shopify_app` for Rails. Works for Laravel 7 and up.
1111

1212
![Screenshot](https://github.com/osiset/laravel-shopify/raw/master/screenshot.png)
1313
![Screenshot: Billable](https://github.com/osiset/laravel-shopify/raw/master/screenshot-billable.png)

composer.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,9 @@
1717
"require": {
1818
"php": ">=7.2",
1919
"doctrine/dbal": "~2.5",
20-
"funeralzone/valueobjects": "^0.4.5",
20+
"funeralzone/valueobjects": "^0.5",
2121
"jenssegers/agent": "^2.6",
22-
"laravel/framework": "~5.8 || ^6.0 || ^7.0 || ^8.0",
22+
"laravel/framework": "^7.0 || ^8.0",
2323
"osiset/basic-shopify-api": "^9.0 || ^10.0"
2424
},
2525
"require-dev": {

0 commit comments

Comments
 (0)