Fix to peruser/offline token check

Author: Tyler King

src/ShopifyApp/Traits/ShopModel.php

@@ -114,7 +114,7 @@ public function isFreemium(): bool
      */
     public function hasOfflineAccess(): bool
     {
-        return ! $this->getToken()->isNull();
+        return ! $this->getToken()->isNull() && !empty($this->password);
     }
 
     /**

tests/Traits/ShopModelTest.php

@@ -35,6 +35,21 @@ public function testModel(): void
         $this->assertInstanceOf(IApiHelper::class, $shop->apiHelper());
     }
 
+    public function testOfflineToken(): void
+    {
+        // No token
+        $shop = factory($this->model)->create([
+            'password' => '',
+        ]);
+        $this->assertFalse($shop->hasOfflineAccess());
+
+        // With token
+        $shop->password = 'abc123';
+        $shop->save();
+        $shop->refresh();
+        $this->assertTrue($shop->hasOfflineAccess());
+    }
+
     public function testNamespacingAndFreemium()
     {
         $this->app['config']->set('shopify-app.billing_freemium_enabled', true);