Skip to content

[Infra] - Update JavaLanguageVersion to 17 as Default #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 10, 2023

Conversation

madebymozart
Copy link
Contributor

@madebymozart madebymozart commented Jul 7, 2023

Description

This CL updates the default JavaLanguageVersion to 17.

The project was using an old version (JavaLanguageVersion = 11) that doesn't come preinstalled on new systems as well as not installed on Android Studio Flamingo Patch 2.

This would make developers encounter this error:
Screenshot 2023-07-07 at 2 19 50 PM

The default of the latest Android Studio Version is 17 when freshly installed:
Screenshot 2023-07-07 at 2 21 29 PM

How Has This Been Tested?

Compile the platform-samples app to a devices as well as use a fresh install of Android Studio that will usually default point to jbt-17 (Jetbrains Runtime version 17.06) as of Android Studio Flamingo Patch 2

Test Configuration #1 - Pixel 7 Pro API 34 Beta (Android 14 Beta)

Checklist:

  • I have performed a self-review of my code
  • [] I have commented my code, particularly in hard-to-understand areas
  • [] I have made corresponding changes to the documentation

@madebymozart madebymozart added bug Something isn't working enhancement New feature or request labels Jul 7, 2023
@madebymozart madebymozart requested a review from marcelpinto July 7, 2023 18:21
@madebymozart madebymozart self-assigned this Jul 7, 2023
@madebymozart madebymozart changed the title [Infra] Update JavaLanguageVersion to 17 as Default [Infra] - Update JavaLanguageVersion to 17 as Default Jul 7, 2023
@marcelpinto marcelpinto merged commit 5cfac38 into main Jul 10, 2023
@marcelpinto marcelpinto deleted the update-jdk-to-17 branch July 10, 2023 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants