Update build.yml #277
Merged
Update build.yml #277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change to upload-artifact@v4
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello @javadude, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request updates the GitHub Actions workflow file .github/workflows/build.yml to use version 4 of the actions/upload-artifact action. The changes involve updating the uses field for the Upload build outputs (APKs), Upload build reports, and Upload test reports steps from actions/upload-artifact@v3 to actions/upload-artifact@v4. Additionally, the overwrite: true parameter is added to each of these steps to ensure that any existing artifacts with the same name are overwritten.
Highlights
- Action Version Update: The pull request updates the
actions/upload-artifactaction from version 3 to version 4 in the workflow file. - Artifact Overwrite: The pull request adds the
overwrite: trueparameter to the artifact upload steps to ensure that existing artifacts are overwritten.
Changelog
- .github/workflows/build.yml
- Updated
usesfield forUpload build outputs (APKs)fromactions/upload-artifact@v3toactions/upload-artifact@v4. - Added
overwrite: truetoUpload build outputs (APKs)step. - Updated
usesfield forUpload build reportsfromactions/upload-artifact@v3toactions/upload-artifact@v4. - Added
overwrite: truetoUpload build reportsstep. - Updated
usesfield forUpload test reportsfromactions/upload-artifact@v3toactions/upload-artifact@v4. - Added
overwrite: truetoUpload test reportsstep.
- Updated
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Trivia time!
What is YAML short for, the language used to define the Github Actions workflow?
Click here for the answer
YAML stands for "YAML Ain't Markup Language". It's a human-readable data-serialization language. It is commonly used for configuration files and in applications where data is being stored or transmitted.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
The pull request updates the GitHub Actions workflow to use version 4 of the upload-artifact action and adds the overwrite: true parameter. The changes look good.
Summary of Findings
- Overwrite Parameter: The
overwrite: trueparameter is added to theupload-artifactaction. It's important to understand the implications of this parameter and ensure it's the desired behavior.
Assessment
The pull request updates the GitHub Actions workflow to use version 4 of the upload-artifact action and adds the overwrite: true parameter. These changes seem reasonable and should improve the reliability of the workflow. I have added a comment regarding the potential need for the overwrite parameter. I would recommend addressing this comment before requesting a review from someone else, but feel free to request another review from Gemini via /gemini review when you have addressed these comments and I'll take another look! Note that in any circumstance, users should have others review and approve this code before merging.
yrezgui
approved these changes
Feb 27, 2025
yrezgui
added a commit
that referenced
this pull request
Mar 8, 2025
* Delete the outdated button widget demo code. - "rv" is not recommended and "glance" is the preferred widget framework. - Sizing on those widgets is off. The new canonical layouts are recommended. * Delete the outdated list widget demo code. - "rv" is not recommended and "glance" is the preferred widget framework. - Sizing on those widgets is off. The new canonical layout contain example of lists and are recommended. * Delete the outdated image widget demo code. - Glance library's demo directory has code samples for individual components. Here is example of Image widget: https://cs.android.com/androidx/platform/frameworks/support/+/androidx-main:glance/glance-appwidget/integration-tests/demos/src/main/java/androidx/glance/appwidget/demos/ImageAppWidget.kt;bpv=1 * Align the AppWidgets showcase entrypoint to highlight canonical layout samples. The main "AppWidgets" page now displays link to the canonical layout showcase page and then below it, demonstrates the functionality to pin and show widget information. * Adjust size and preview of the weather widget in platform samples. - 4x2 is the recommended size for such widget - avoid 3x? sizes - Uses glance loading layout resource instead of the local xml - Update the preview image * Update background color of the xml based weather widget - To closely match the appWidgetBackground color used in glance. * Update Glance weather widget to use Scaffold. - The Scaffold component in glance handles the background color, widget radius for you. - For the inner content, calculate widget radius based on the padding and system radius. * Align the AppWidgets showcase entrypoint to highlight canonical layout samples. The main "AppWidgets" page now displays link to the canonical layout showcase page and then below it, demonstrates the functionality to pin and show widget information. * fixup! Update Glance weather widget to use Scaffold. * Update the readMe section with screenshots of canonical widget layouts * Update the readMe section with screenshots of canonical widget layouts * Update the readMe section with screenshots of canonical widget layouts * Replace Casa framework with a lighter structure * Remove Casa from these following modules: - accessibility - camera2 - connectivity call notification - graphics pdf - graphics ultrahdr - privacy transparency - storage * Remove Casa from these following modules: - connectivity - location - media - privacy * Fix permissions module * Add appwidgets & constraintlayout samples * Add more user interface samples * Add last samples * Update build.yml (#277) Change to upload-artifact@v4 * Add MinSdkBox composable to wrap samples using recent APIs * Fix Activity insets * Add missing test dependencies Add various lint ignore checks on minSdk * Update README.md - Remove samples README.md as it has been unreliably generated recently - We may reinvest in the idea later on * Remove duplicate MAIN/LAUNCHER intent filters from samples * Temporarily ignore a flaky test in PiPMovieActivityTest * Refactor: Replace `Area` with `ApiSurface` for better context Replaced the `Area` data class with `ApiSurface` to more accurately represent the categories of samples in the app. Updated all references in `NavGraph`, `SampleDemo`, and `CatalogScreen` to reflect this change. The update introduces the `ApiSurface` interface and its implementations to categorize the different areas of platform features and functionality demonstrated by the samples. * Temporarily disable unit tests in CI Disables unit tests in the CI build workflow. * Replace Casa framework with a lighter structure * Remove Casa from these following modules: - accessibility - camera2 - connectivity call notification - graphics pdf - graphics ultrahdr - privacy transparency - storage * Remove Casa from these following modules: - connectivity - location - media - privacy * Fix permissions module * Add appwidgets & constraintlayout samples * Add more user interface samples * Add last samples * Add MinSdkBox composable to wrap samples using recent APIs * Fix Activity insets * Add missing test dependencies Add various lint ignore checks on minSdk * Update README.md - Remove samples README.md as it has been unreliably generated recently - We may reinvest in the idea later on * Remove duplicate MAIN/LAUNCHER intent filters from samples * Temporarily ignore a flaky test in PiPMovieActivityTest * Refactor: Replace `Area` with `ApiSurface` for better context Replaced the `Area` data class with `ApiSurface` to more accurately represent the categories of samples in the app. Updated all references in `NavGraph`, `SampleDemo`, and `CatalogScreen` to reflect this change. The update introduces the `ApiSurface` interface and its implementations to categorize the different areas of platform features and functionality demonstrated by the samples. * Temporarily disable unit tests in CI Disables unit tests in the CI build workflow. * Rebase app widgets description from main branch --------- Co-authored-by: Shamali P <shamalip@google.com> Co-authored-by: Scott Stanchfield <scott@javadude.com> Co-authored-by: Hoyt Summers Pittman <secondsun@gmail.com>
yrezgui
added a commit
that referenced
this pull request
Mar 10, 2025
* Delete the outdated button widget demo code. - "rv" is not recommended and "glance" is the preferred widget framework. - Sizing on those widgets is off. The new canonical layouts are recommended. * Delete the outdated list widget demo code. - "rv" is not recommended and "glance" is the preferred widget framework. - Sizing on those widgets is off. The new canonical layout contain example of lists and are recommended. * Delete the outdated image widget demo code. - Glance library's demo directory has code samples for individual components. Here is example of Image widget: https://cs.android.com/androidx/platform/frameworks/support/+/androidx-main:glance/glance-appwidget/integration-tests/demos/src/main/java/androidx/glance/appwidget/demos/ImageAppWidget.kt;bpv=1 * Align the AppWidgets showcase entrypoint to highlight canonical layout samples. The main "AppWidgets" page now displays link to the canonical layout showcase page and then below it, demonstrates the functionality to pin and show widget information. * Adjust size and preview of the weather widget in platform samples. - 4x2 is the recommended size for such widget - avoid 3x? sizes - Uses glance loading layout resource instead of the local xml - Update the preview image * Update background color of the xml based weather widget - To closely match the appWidgetBackground color used in glance. * Update Glance weather widget to use Scaffold. - The Scaffold component in glance handles the background color, widget radius for you. - For the inner content, calculate widget radius based on the padding and system radius. * Align the AppWidgets showcase entrypoint to highlight canonical layout samples. The main "AppWidgets" page now displays link to the canonical layout showcase page and then below it, demonstrates the functionality to pin and show widget information. * fixup! Update Glance weather widget to use Scaffold. * Update the readMe section with screenshots of canonical widget layouts * Update the readMe section with screenshots of canonical widget layouts * Update the readMe section with screenshots of canonical widget layouts * Replace Casa framework with a lighter structure * Remove Casa from these following modules: - accessibility - camera2 - connectivity call notification - graphics pdf - graphics ultrahdr - privacy transparency - storage * Remove Casa from these following modules: - connectivity - location - media - privacy * Fix permissions module * Add appwidgets & constraintlayout samples * Add more user interface samples * Add last samples * Update build.yml (#277) Change to upload-artifact@v4 * Add MinSdkBox composable to wrap samples using recent APIs * Fix Activity insets * Add missing test dependencies Add various lint ignore checks on minSdk * Update README.md - Remove samples README.md as it has been unreliably generated recently - We may reinvest in the idea later on * Remove duplicate MAIN/LAUNCHER intent filters from samples * Temporarily ignore a flaky test in PiPMovieActivityTest * Refactor: Replace `Area` with `ApiSurface` for better context Replaced the `Area` data class with `ApiSurface` to more accurately represent the categories of samples in the app. Updated all references in `NavGraph`, `SampleDemo`, and `CatalogScreen` to reflect this change. The update introduces the `ApiSurface` interface and its implementations to categorize the different areas of platform features and functionality demonstrated by the samples. * Temporarily disable unit tests in CI Disables unit tests in the CI build workflow. * Replace Casa framework with a lighter structure * Remove Casa from these following modules: - accessibility - camera2 - connectivity call notification - graphics pdf - graphics ultrahdr - privacy transparency - storage * Remove Casa from these following modules: - connectivity - location - media - privacy * Fix permissions module * Add appwidgets & constraintlayout samples * Add more user interface samples * Add last samples * Add MinSdkBox composable to wrap samples using recent APIs * Fix Activity insets * Add missing test dependencies Add various lint ignore checks on minSdk * Update README.md - Remove samples README.md as it has been unreliably generated recently - We may reinvest in the idea later on * Remove duplicate MAIN/LAUNCHER intent filters from samples * Temporarily ignore a flaky test in PiPMovieActivityTest * Refactor: Replace `Area` with `ApiSurface` for better context Replaced the `Area` data class with `ApiSurface` to more accurately represent the categories of samples in the app. Updated all references in `NavGraph`, `SampleDemo`, and `CatalogScreen` to reflect this change. The update introduces the `ApiSurface` interface and its implementations to categorize the different areas of platform features and functionality demonstrated by the samples. * Temporarily disable unit tests in CI Disables unit tests in the CI build workflow. * Rebase app widgets description from main branch --------- Co-authored-by: Shamali P <shamalip@google.com> Co-authored-by: Scott Stanchfield <scott@javadude.com> Co-authored-by: Hoyt Summers Pittman <secondsun@gmail.com>
|
/gemini summarize |
Summary of ChangesThis pull request updates the Highlights
Changelog
Activity
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change to upload-artifact@v4