-
Notifications
You must be signed in to change notification settings - Fork 348
Remove duplicate LAUNCHER declaration #270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Hi @tjohns @bentrengrove @javadude @tnorbye , Could you please help me review this PR. |
Good catch; thanks! This will simplify the user experience. However, the entire
should become
|
There's no need to declare in samples' manifest. Otherwise, it will create more icons in launcher.
I'm updating the build.yaml in PR #277 to move to the required upload-artifact@v4. Once merged, you'll need to merge in the change for this build to pass, then we can merge this PR. |
The build update was merged. Please merge main into your branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/gemini summarize |
Warning Gemini encountered an error creating the summary. You can try again by commenting |
There's no need to declare in samples' manifest.
Otherwise, it will create more icons in launcher.