Implement Camera2 - Image Capture Sample #23

madebymozart · 2023-05-23T15:33:34Z

Description

This CL contains sample code for Camera2 Image Capture. This sample demonstrate how a developer can capture and image using the Camera2 APIs. This sample also demonstrate howt o display the captured image via the ImageViewerFragment class

How Has This Been Tested?

This sample app was tested on 3 devices on 3 different version of android:

Test Configuration #1 - Pixel 6 Pro API 33 (Android 13)
**Test Configuration #2 - Samsung Galaxy S22 Ultra (Android 12) **
Test Configuration #3 - Pixel 5a With 5G (Android 11)

Checklist:

I have performed a self-review of my code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation

Screenshots

marcelpinto · 2023-05-24T10:58:25Z

samples/camera/camera2/build.gradle.kts

@@ -24,6 +24,14 @@ android {
 }

 dependencies {
-    // Add samples specific dependencies
+    // EXIF Interface
+    implementation("androidx.exifinterface:exifinterface:1.3.6")


Use catalog format https://developer.android.com/build/migrate-to-catalogs

marcelpinto · 2023-05-24T10:59:36Z

samples/camera/camera2/build.gradle.kts

+    implementation("androidx.viewpager2:viewpager2:1.0.0")
+
+    // Glide
+    implementation("com.github.bumptech.glide:glide:4.15.1")


The project already uses Coil for image loading. Could you use that instead?
https://github.com/coil-kt/coil

marcelpinto · 2023-05-24T11:04:19Z

...camera/camera2/src/main/java/com/example/platform/camera/imagecapture/Camera2ImageCapture.kt

+    description = "This sample demonstrates how to capture and image and encode it into a JPEG "
+            + "container. Includes enable torch (flash) support is available.",
+    documentation = "https://developer.android.com/training/camera2/capture-sessions-requests",
+    owners = ["Mozart Louis (mozart@google.com)"],


Let's avoid this feature. Better not to expose your email in the codebase + owners tend to change quite fast and we rather track this internally

marcelpinto · 2023-05-24T11:04:54Z

...camera/camera2/src/main/java/com/example/platform/camera/imagecapture/Camera2ImageCapture.kt

+@Sample(
+    name = "Camera2 - Image Capture",
+    description = "This sample demonstrates how to capture and image and encode it into a JPEG "
+            + "container. Includes enable torch (flash) support is available.",


"if it's available?"

Some Devices don't have a touch light (Flash Capabilities)

Sure, but I mean the sentence is not correct.

Includes enable torch (flash) support when available.

or

Includes enable torch (flash) support if it's available.

Ah I see what you mean, Correcting in the next commit

marcelpinto · 2023-05-24T11:16:12Z

samples/camera/camera2/src/main/AndroidManifest.xml

@@ -18,6 +18,7 @@

    <uses-permission android:name="android.permission.CAMERA" />
    <uses-permission android:name="android.permission.RECORD_AUDIO" />
+    <uses-permission android:name="android.permission.POST_NOTIFICATIONS" />


I don't see it being used btw. Is it needed?

I originally meant for it to be used to send a quick notification so the user can view the photos in an external viewer, but not needed anymore. Will remove

marcelpinto · 2023-05-24T11:20:32Z

samples/camera/camera2/src/main/java/com/example/platform/camera/common/ImageViewerFragment.kt

+import java.io.File
+import kotlin.math.max
+
+class ImageViewerFragment(


You should not pass argument like this in a fragment.
https://developer.android.com/guide/fragments/create#add-programmatic

marcelpinto · 2023-06-14T08:11:39Z

...camera/camera2/src/main/java/com/example/platform/camera/imagecapture/Camera2ImageCapture.kt

+                        binding.fragmentCamera2ImageCaptureViewfinder.visibility = View.GONE
+                        binding.fragmentCamera2ImageCaptureButton.visibility = View.GONE
+
+                        parentFragmentManager.commit {


The simple image viewer is already part of this fragment. You don't need the commit right?

marcelpinto · 2023-06-14T08:13:24Z

...camera/camera2/src/main/java/com/example/platform/camera/imagecapture/Camera2ImageCapture.kt

+                        binding.fragmentCamera2ImageCaptureButton.visibility = View.GONE
+
+                        parentFragmentManager.commit {
+                            binding.fragmentCamera2ImageCaptureImageView.setContent {


How are you handling the back navigation? Once you set the content the image will take most of the screen and user cannot remove it right?

marcelpinto · 2023-06-15T07:25:39Z

...camera/camera2/src/main/java/com/example/platform/camera/imagecapture/Camera2ImageCapture.kt

+    private fun returnToImageCapture() {
+        binding.fragmentCamera2ImageCaptureButton.visibility = View.VISIBLE
+        binding.fragmentCamera2PostCaptureBackButton.visibility = View.GONE
+        binding.fragmentCamera2ImageCaptureImageView.setContent {  }


Nit: if you make it gone there is probably no need to set an empty content

- Update to Coil & Glide - Update to FragmentContainerView - Other nits

madebymozart requested a review from marcelpinto May 23, 2023 15:33

madebymozart self-assigned this May 23, 2023

madebymozart added the new sample This denotes the creation of a new sample in the platform samples app label May 23, 2023

madebymozart force-pushed the camera2-imagecapture branch 2 times, most recently from f14dfb1 to 1160bff Compare May 23, 2023 15:41

android deleted a comment from google-cla bot May 23, 2023

marcelpinto suggested changes May 24, 2023

View reviewed changes

marcelpinto reviewed May 24, 2023

View reviewed changes

marcelpinto suggested changes May 24, 2023

View reviewed changes

madebymozart force-pushed the camera2-imagecapture branch from fb1bbdb to 9c5ff19 Compare June 8, 2023 21:33

madebymozart requested a review from marcelpinto June 12, 2023 16:43

marcelpinto reviewed Jun 14, 2023

View reviewed changes

madebymozart force-pushed the camera2-imagecapture branch from b87f495 to 4a28e64 Compare June 14, 2023 17:28

marcelpinto approved these changes Jun 15, 2023

View reviewed changes

Mozart Louis and others added 5 commits June 20, 2023 12:13

Implement Camera2 Image Capture Sample

6f0bee1

Fixed lint issues

09026ab

pr nits

db7e127

- Update to Coil & Glide - Update to FragmentContainerView - Other nits

Implement "SimpleImageViewer" using compose to display taken image.

8071892

Added back button to return to camera preview

6bb0fa5

madebymozart force-pushed the camera2-imagecapture branch from 4a28e64 to 6bb0fa5 Compare June 20, 2023 21:03

madebymozart merged commit 6e27e45 into main Jun 22, 2023

madebymozart deleted the camera2-imagecapture branch June 22, 2023 06:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Implement Camera2 - Image Capture Sample #23

Implement Camera2 - Image Capture Sample #23

Uh oh!

madebymozart commented May 23, 2023 •

edited

Loading

Uh oh!

marcelpinto May 24, 2023

Uh oh!

marcelpinto May 24, 2023

Uh oh!

marcelpinto May 24, 2023

Uh oh!

marcelpinto May 24, 2023

Uh oh!

madebymozart May 30, 2023

Uh oh!

marcelpinto May 31, 2023

Uh oh!

madebymozart Jun 5, 2023

Uh oh!

marcelpinto May 24, 2023

Uh oh!

madebymozart Jun 5, 2023 •

edited

Loading

Uh oh!

marcelpinto May 24, 2023

Uh oh!

marcelpinto Jun 14, 2023

Uh oh!

marcelpinto Jun 14, 2023

Uh oh!

marcelpinto Jun 15, 2023

Uh oh!

Uh oh!

Implement Camera2 - Image Capture Sample #23

Implement Camera2 - Image Capture Sample #23

Uh oh!

Conversation

madebymozart commented May 23, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

How Has This Been Tested?

Checklist:

Screenshots

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

madebymozart Jun 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

madebymozart commented May 23, 2023 •

edited

Loading

madebymozart Jun 5, 2023 •

edited

Loading