[Sample] [Graphics] UltraHDR x OpenGL shaders with SurfaceView brightness control #131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaraki
reviewed
Dec 8, 2023
samples/graphics/ultrahdr/src/main/res/layout/ultrahdr_with_graphics.xml
Show resolved
Hide resolved
nadewad
reviewed
Dec 13, 2023
gradle/libs.versions.toml
Outdated
| @@ -124,6 +124,7 @@ androidx-work-runtime-ktx = "androidx.work:work-runtime-ktx:2.8.1" | |||
| androidx-core-remoteviews = "androidx.core:core-remoteviews:1.0.0" | |||
| androidx-glance-appwidget = "androidx.glance:glance-appwidget:1.0.0" | |||
| androidx-glance-material3 = "androidx.glance:glance-material3:1.0.0" | |||
| androidx-graphics-core = { group = "androidx.graphics", name = "graphics-core", version = "1.0.0-alpha05" } | |||
There was a problem hiding this comment.
Note as of Dec 13th the 1.0.0-beta01 release of the graphics-core library is now available.
There was a problem hiding this comment.
Updated it in latest patch
nadewad
reviewed
Dec 13, 2023
| transaction.setDataSpace(targetSurfaceControl, if (isWideGamut) P3_XRB else SRGB_XRB) | ||
| transaction.setExtendedRangeBrightness(targetSurfaceControl, hdrSdrRatio, desiredRatio) | ||
| transaction.commit() | ||
| super.onDrawComplete(targetSurfaceControl, transaction, frameBuffer, syncFence) |
There was a problem hiding this comment.
Just FYI, delegation to the base class method is not necessary.
Also the implementation of GLFrameBufferRenderer already calls transaction.commit on your behalf so explicitly calling commit here is not necessary.
There was a problem hiding this comment.
👍🏾 Perfect - Thanks for letting me know
yaraki
approved these changes
Dec 15, 2023
# Conflicts: # samples/README.md # samples/graphics/ultrahdr/src/main/res/values/strings.xml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR uses UltraHDR image, and processes them through a OpenGL pipeline using fragment & vertex shaders. This then displays the output frame on the SurfaceView and shows the developer how to control the brightness of the UltraHDR Image.
The included fragment shader is a tone-mapping shader. Big thanks for @johnreck for the graphics code here!
How Has This Been Tested?
Test Configuration #1 - Pixel 8 Pro API 34 Beta (Android 14)
Test Configuration #1 - Pixel 7 Pro API 34 Beta (Android 14 Beta)
Demo
Recording
Screen_recording_20231206_124542.mp4