Skip to content

Conversation

@ashnohe
Copy link
Contributor

@ashnohe ashnohe commented Oct 17, 2025

Before:

before

After:

after_regular after_large_screen

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @ashnohe, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses and rectifies issues with the application's display on edge-to-edge screens. By updating core dependencies and migrating to a more robust edge-to-edge API, the changes ensure that the UI elements correctly adapt to the full screen real estate, providing a seamless and immersive user experience across various device form factors, as demonstrated by the before and after screenshots.

Highlights

  • Dependency Update: Updated the androidx-corektx dependency from version 1.16.0 to 1.17.0 to ensure compatibility with the latest edge-to-edge features.
  • Edge-to-Edge API Migration: Migrated the application's edge-to-edge implementation from the deprecated enableEdgeToEdge() function to the WindowCompat.enableEdgeToEdge(window) API in MainActivity.kt for better system integration and modern Android practices.
  • Home Screen Inset Handling: Adjusted the HomeScreen layout to correctly apply window insets, allowing content to extend behind system navigation bars while maintaining proper padding for interactive elements. This includes specific handling for LazyVerticalGrid to ensure scrollability.
  • Player Screen Padding Refinement: Refactored the PlayerScreen to remove explicit contentPadding application, resolving potential conflicts with the new edge-to-edge display and ensuring the background extends fully to the screen edges.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly updates the application to support edge-to-edge display by replacing the deprecated enableEdgeToEdge() with WindowCompat.enableEdgeToEdge(window) and adjusting inset handling in the home and player screens. The changes are a good step towards modernizing the UI. However, I've identified a few issues related to inset handling that could lead to UI bugs, such as content being obscured by the status bar or other UI elements. I've left detailed comments with suggestions on how to address these.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants