-
Couldn't load subscription status.
- Fork 5.3k
Fix edge-to-edge screens #1618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix edge-to-edge screens #1618
Conversation
Summary of ChangesHello @ashnohe, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses and rectifies issues with the application's display on edge-to-edge screens. By updating core dependencies and migrating to a more robust edge-to-edge API, the changes ensure that the UI elements correctly adapt to the full screen real estate, providing a seamless and immersive user experience across various device form factors, as demonstrated by the before and after screenshots. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly updates the application to support edge-to-edge display by replacing the deprecated enableEdgeToEdge() with WindowCompat.enableEdgeToEdge(window) and adjusting inset handling in the home and player screens. The changes are a good step towards modernizing the UI. However, I've identified a few issues related to inset handling that could lead to UI bugs, such as content being obscured by the status bar or other UI elements. I've left detailed comments with suggestions on how to address these.
Before:
After: