[lint] minor fixes

Author: capcom6

.github/workflows/release.yml

@@ -64,7 +64,7 @@ jobs:
         run: echo APP_VERSION=${GITHUB_REF#refs/tags/} >> ${GITHUB_ENV}
 
       - name: Checkout code
-        uses: actions/checkout@v3
+        uses: actions/checkout@v5
 
       - name: Install Terraform
         uses: hashicorp/setup-terraform@v3

Dockerfile.goreleaser

@@ -1,4 +1,4 @@
-FROM alpine:3
+FROM alpine:3.22
 
 ARG TARGETPLATFORM
 ARG BINARY_NAME

Makefile

@@ -7,7 +7,10 @@ ifeq ($(OS),Windows_NT)
 	extension = .exe
 endif
 
-.PHONY: all fmt lint test coverage benchmark deps release clean help
+.PHONY: \
+	all fmt lint test coverage benchmark deps release clean help \
+	init init-dev ngrok air db-upgrade db-upgrade-raw run test-e2e build install \
+	docker-build docker docker-dev docker-clean
 
 all: fmt lint test benchmark ## Run all tests and checks
 
@@ -84,5 +87,3 @@ docker-dev:
 
 docker-clean:
 	docker compose -f deployments/docker-compose/docker-compose.yml down --volumes
-
-.PHONY: init init-dev ngrok air db-upgrade db-upgrade-raw run test-e2e build install docker-build docker docker-dev docker-clean

internal/config/config.go

@@ -82,7 +82,8 @@ type Cache struct {
 }
 
 type PubSub struct {
-	URL string `yaml:"url" envconfig:"PUBSUB__URL"`
+	URL        string `yaml:"url"         envconfig:"PUBSUB__URL"`
+	BufferSize uint   `yaml:"buffer_size" envconfig:"PUBSUB__BUFFER_SIZE"`
 }
 
 func Default() Config {
@@ -119,7 +120,8 @@ func Default() Config {
 			URL: "memory://",
 		},
 		PubSub: PubSub{
-			URL: "memory://",
+			URL:        "memory://",
+			BufferSize: 128,
 		},
 	}
 }

internal/config/module.go

@@ -115,7 +115,7 @@ func Module() fx.Option {
 				) * time.Second,
 			}
 		}),
-		fx.Provide(func(cfg Config) devices.Config {
+		fx.Provide(func(_ Config) devices.Config {
 			return devices.Config{
 				UnusedLifetime: 365 * 24 * time.Hour, //TODO: make it configurable
 			}
@@ -133,7 +133,7 @@ func Module() fx.Option {
 		fx.Provide(func(cfg Config) pubsub.Config {
 			return pubsub.Config{
 				URL:        cfg.PubSub.URL,
-				BufferSize: 128,
+				BufferSize: cfg.PubSub.BufferSize,
 			}
 		}),
 	)

internal/sms-gateway/cache/factory.go

@@ -28,7 +28,7 @@ func NewFactory(config Config) (Factory, error) {
 
 	u, err := url.Parse(config.URL)
 	if err != nil {
-		return nil, fmt.Errorf("%w: can't parse url: %w", ErrInvalidConfig, err)
+		return nil, fmt.Errorf("%w: failed to parse url: %w", ErrInvalidConfig, err)
 	}
 
 	switch u.Scheme {

internal/sms-gateway/handlers/base/handler.go

@@ -19,23 +19,23 @@ type Handler struct {
 
 func (h *Handler) BodyParserValidator(c *fiber.Ctx, out any) error {
 	if err := c.BodyParser(out); err != nil {
-		return fiber.NewError(fiber.StatusBadRequest, fmt.Sprintf("Can't parse body: %s", err.Error()))
+		return fiber.NewError(fiber.StatusBadRequest, fmt.Sprintf("failed to parse body: %s", err.Error()))
 	}
 
 	return h.ValidateStruct(out)
 }
 
 func (h *Handler) QueryParserValidator(c *fiber.Ctx, out any) error {
 	if err := c.QueryParser(out); err != nil {
-		return fiber.NewError(fiber.StatusBadRequest, fmt.Sprintf("Can't parse query: %s", err.Error()))
+		return fiber.NewError(fiber.StatusBadRequest, fmt.Sprintf("failed to parse query: %s", err.Error()))
 	}
 
 	return h.ValidateStruct(out)
 }
 
 func (h *Handler) ParamsParserValidator(c *fiber.Ctx, out any) error {
 	if err := c.ParamsParser(out); err != nil {
-		return fiber.NewError(fiber.StatusBadRequest, fmt.Sprintf("Can't parse params: %s", err.Error()))
+		return fiber.NewError(fiber.StatusBadRequest, fmt.Sprintf("failed to parse params: %s", err.Error()))
 	}
 
 	return h.ValidateStruct(out)

internal/sms-gateway/handlers/devices/3rdparty.go

@@ -50,7 +50,7 @@ func NewThirdPartyController(
 func (h *ThirdPartyController) get(user models.User, c *fiber.Ctx) error {
 	devices, err := h.devicesSvc.Select(user.ID)
 	if err != nil {
-		return fmt.Errorf("can't select devices: %w", err)
+		return fmt.Errorf("failed to select devices: %w", err)
 	}
 
 	response := slices.Map(devices, converters.DeviceToDTO)
@@ -80,7 +80,7 @@ func (h *ThirdPartyController) remove(user models.User, c *fiber.Ctx) error {
 		return fiber.NewError(fiber.StatusNotFound, err.Error())
 	}
 	if err != nil {
-		return fmt.Errorf("can't remove device: %w", err)
+		return fmt.Errorf("failed to remove device: %w", err)
 	}
 
 	return c.SendStatus(fiber.StatusNoContent)

internal/sms-gateway/handlers/messages/3rdparty.go

@@ -144,7 +144,7 @@ func (h *ThirdPartyController) post(user models.User, c *fiber.Ctx) error {
 			return fiber.NewError(fiber.StatusConflict, err.Error())
 		}
 
-		return fmt.Errorf("can't enqueue message: %w", err)
+		return fmt.Errorf("failed to enqueue message: %w", err)
 	}
 
 	location, err := c.GetRouteURL(route3rdPartyGetMessage, fiber.Map{

internal/sms-gateway/handlers/messages/mobile.go

@@ -64,7 +64,7 @@ func (h *MobileController) list(device models.Device, c *fiber.Ctx) error {
 
 	msgs, err := h.messagesSvc.SelectPending(device.ID, params.OrderOrDefault())
 	if err != nil {
-		return fmt.Errorf("can't get messages: %w", err)
+		return fmt.Errorf("failed to get messages: %w", err)
 	}
 
 	return c.JSON(
@@ -106,7 +106,7 @@ func (h *MobileController) patch(device models.Device, c *fiber.Ctx) error {
 
 		err := h.messagesSvc.UpdateState(&device, messageState)
 		if err != nil && !errors.Is(err, messages.ErrMessageNotFound) {
-			h.Logger.Error("Can't update message status",
+			h.Logger.Error("failed to update message status",
 				zap.String("message_id", v.ID),
 				zap.Error(err),
 			)