[online] fix edge cases

Author: capcom6

internal/sms-gateway/modules/auth/service.go

@@ -145,8 +145,8 @@ func (s *Service) AuthorizeDevice(token string) (models.Device, error) {
 
 	go func(id string) {
 		ctx, cancel := context.WithTimeout(context.Background(), 5*time.Second)
+		defer cancel()
 		s.onlineSvc.SetOnline(ctx, id)
-		cancel()
 	}(device.ID)
 
 	device.LastSeen = time.Now()

internal/sms-gateway/modules/devices/repository.go

@@ -72,11 +72,19 @@ func (r *repository) UpdatePushToken(id, token string) error {
 }
 
 func (r *repository) SetLastSeen(ctx context.Context, id string, lastSeen time.Time) error {
-	return r.db.WithContext(ctx).
+	if lastSeen.IsZero() {
+		return nil // ignore zero timestamps
+	}
+	res := r.db.WithContext(ctx).
 		Model(&models.Device{}).
-		Where("id", id).
-		Update("last_seen", lastSeen).
-		Error
+		Where("id = ? AND last_seen < ?", id, lastSeen).
+		Update("last_seen", lastSeen)
+	if res.Error != nil {
+		return res.Error
+	}
+
+	// RowsAffected==0 => not found or stale timestamp; treat as no-op.
+	return nil
 }
 
 func (r *repository) Remove(filter ...SelectFilter) error {

internal/sms-gateway/modules/devices/service.go

@@ -101,13 +101,21 @@ func (s *Service) UpdatePushToken(deviceId string, token string) error {
 }
 
 func (s *Service) SetLastSeen(ctx context.Context, batch map[string]time.Time) error {
+	if len(batch) == 0 {
+		return nil
+	}
+
 	for deviceId, lastSeen := range batch {
+		if ctx.Err() != nil {
+			break
+		}
+
 		if err := s.devices.SetLastSeen(ctx, deviceId, lastSeen); err != nil {
 			s.logger.Error("can't set last seen", zap.String("device_id", deviceId), zap.Error(err))
 		}
 	}
 
-	return nil
+	return ctx.Err()
 }
 
 // Remove removes devices for a specific user that match the provided filters.

internal/sms-gateway/online/service.go

@@ -43,11 +43,9 @@ func (s *service) Run(ctx context.Context) {
 		case <-ctx.Done():
 			return
 		case <-ticker.C:
-			s.logger.Info("Persisting online status")
+			s.logger.Debug("Persisting online status")
 			if err := s.persist(ctx); err != nil {
 				s.logger.Error("Can't persist online status", zap.Error(err))
-			} else {
-				s.logger.Info("Online status persisted")
 			}
 		}
 	}
@@ -72,7 +70,11 @@ func (s *service) persist(ctx context.Context) error {
 		return fmt.Errorf("can't drain cache: %w", err)
 	}
 
-	s.logger.Info("Drained cache", zap.Int("count", len(items)))
+	if len(items) == 0 {
+		s.logger.Debug("No online statuses to persist")
+		return nil
+	}
+	s.logger.Debug("Drained cache", zap.Int("count", len(items)))
 
 	timestamps := maps.MapValues(items, func(v string) time.Time {
 		t, err := time.Parse(time.RFC3339, v)
@@ -84,7 +86,7 @@ func (s *service) persist(ctx context.Context) error {
 		return t
 	})
 
-	s.logger.Info("Parsed last seen timestamps", zap.Int("count", len(timestamps)))
+	s.logger.Debug("Parsed last seen timestamps", zap.Int("count", len(timestamps)))
 
 	if err := s.devicesSvc.SetLastSeen(ctx, timestamps); err != nil {
 		return fmt.Errorf("can't set last seen: %w", err)