[lint] minor fixes

Author: capcom6

internal/sms-gateway/handlers/messages/3rdparty.go

@@ -148,7 +148,7 @@ func (h *ThirdPartyController) post(user models.User, c *fiber.Ctx) error {
 	})
 	if err != nil {
 		h.Logger.Warn(
-			"Failed to get route URL",
+			"failed to get route URL",
 			zap.String("route", route3rdPartyGetMessage),
 			zap.String("id", state.ID),
 			zap.Error(err),
@@ -195,8 +195,8 @@ func (h *ThirdPartyController) list(user models.User, c *fiber.Ctx) error {
 
 	messages, total, err := h.messagesSvc.SelectStates(user, params.ToFilter(), params.ToOptions())
 	if err != nil {
-		h.Logger.Error("Failed to get message history", zap.Error(err), zap.String("user_id", user.ID))
-		return fiber.NewError(fiber.StatusInternalServerError, "Failed to retrieve message history")
+		h.Logger.Error("failed to get message history", zap.Error(err), zap.String("user_id", user.ID))
+		return fiber.NewError(fiber.StatusInternalServerError, "failed to retrieve message history")
 	}
 
 	c.Set("X-Total-Count", strconv.Itoa(int(total)))
@@ -272,7 +272,7 @@ func (h *ThirdPartyController) postInboxExport(user models.User, c *fiber.Ctx) e
 	return c.SendStatus(fiber.StatusAccepted)
 }
 
-func (h *ThirdPartyController) errorHanlder(c *fiber.Ctx) error {
+func (h *ThirdPartyController) errorHandler(c *fiber.Ctx) error {
 	err := c.Next()
 	if err == nil {
 		return nil
@@ -306,7 +306,7 @@ func (h *ThirdPartyController) errorHanlder(c *fiber.Ctx) error {
 }
 
 func (h *ThirdPartyController) Register(router fiber.Router) {
-	router.Use(h.errorHanlder)
+	router.Use(h.errorHandler)
 
 	router.Get("", userauth.WithUser(h.list))
 	router.Post("", userauth.WithUser(h.post))

internal/sms-gateway/handlers/settings/3rdparty.go

@@ -85,7 +85,7 @@ func (h *ThirdPartyController) put(user models.User, c *fiber.Ctx) error {
 	settings := make(map[string]any)
 
 	if err := c.BodyParser(&settings); err != nil {
-		return fiber.NewError(fiber.StatusBadRequest, fmt.Sprintf("Failed to parse request body: %v", err))
+		return fiber.NewError(fiber.StatusBadRequest, fmt.Sprintf("failed to parse request body: %v", err))
 	}
 
 	updated, err := h.settingsSvc.ReplaceSettings(user.ID, settings)
@@ -119,7 +119,7 @@ func (h *ThirdPartyController) patch(user models.User, c *fiber.Ctx) error {
 	settings := make(map[string]any)
 
 	if err := c.BodyParser(&settings); err != nil {
-		return fiber.NewError(fiber.StatusBadRequest, fmt.Sprintf("Failed to parse request body: %v", err))
+		return fiber.NewError(fiber.StatusBadRequest, fmt.Sprintf("failed to parse request body: %v", err))
 	}
 
 	updated, err := h.settingsSvc.UpdateSettings(user.ID, settings)

internal/sms-gateway/modules/devices/repository.go

@@ -11,7 +11,7 @@ import (
 )
 
 var (
-	ErrNotFound      = gorm.ErrRecordNotFound
+	ErrNotFound      = errors.New("record not found")
 	ErrInvalidFilter = errors.New("invalid filter")
 	ErrMoreThanOne   = errors.New("more than one record")
 )

internal/sms-gateway/modules/events/module.go

@@ -21,9 +21,9 @@ func Module() fx.Option {
 				OnStart: func(_ context.Context) error {
 					go func() {
 						if err := svc.Run(ctx); err != nil {
-							logger.Error("Error running events service", zap.Error(err))
+							logger.Error("error running events service", zap.Error(err))
 							if shErr := sh.Shutdown(fx.ExitCode(1)); shErr != nil {
-								logger.Error("Failed to shutdown", zap.Error(shErr))
+								logger.Error("failed to shutdown", zap.Error(shErr))
 							}
 						}
 					}()

internal/sms-gateway/modules/events/service.go

@@ -102,7 +102,7 @@ func (s *Service) Run(ctx context.Context) error {
 			wrapper := new(eventWrapper)
 			if jsonErr := wrapper.deserialize(msg.Data); jsonErr != nil {
 				s.metrics.IncrementFailed(EventTypeUnknown, DeliveryTypeUnknown, FailureReasonSerializationError)
-				s.logger.Error("Failed to deserialize event wrapper", zap.Error(jsonErr))
+				s.logger.Error("failed to deserialize event wrapper", zap.Error(jsonErr))
 				continue
 			}
 			s.processEvent(wrapper)
@@ -119,12 +119,12 @@ func (s *Service) processEvent(wrapper *eventWrapper) {
 
 	devices, err := s.deviceSvc.Select(wrapper.UserID, filters...)
 	if err != nil {
-		s.logger.Error("Failed to select devices", zap.String("user_id", wrapper.UserID), zap.Error(err))
+		s.logger.Error("failed to select devices", zap.String("user_id", wrapper.UserID), zap.Error(err))
 		return
 	}
 
 	if len(devices) == 0 {
-		s.logger.Info("No devices found for user", zap.String("user_id", wrapper.UserID))
+		s.logger.Info("no devices found for user", zap.String("user_id", wrapper.UserID))
 		return
 	}
 
@@ -137,7 +137,7 @@ func (s *Service) processEvent(wrapper *eventWrapper) {
 				Data: wrapper.Event.Data,
 			}); enqErr != nil {
 				s.logger.Error(
-					"Failed to enqueue push notification",
+					"failed to enqueue push notification",
 					zap.String("user_id", wrapper.UserID),
 					zap.String("device_id", device.ID),
 					zap.Error(enqErr),
@@ -159,7 +159,7 @@ func (s *Service) processEvent(wrapper *eventWrapper) {
 			Data: wrapper.Event.Data,
 		}); sseErr != nil {
 			s.logger.Error(
-				"Failed to send SSE notification",
+				"failed to send SSE notification",
 				zap.String("user_id", wrapper.UserID),
 				zap.String("device_id", device.ID),
 				zap.Error(sseErr),

internal/sms-gateway/modules/messages/models.go

@@ -70,7 +70,7 @@ func NewMessage(
 		ExtID:    extID,
 		DeviceID: deviceID,
 		Recipients: lo.Map(phoneNumbers, func(item string, _ int) MessageRecipient {
-			return MessageRecipient{PhoneNumber: item, State: ProcessingStatePending}
+			return newMessageRecipient(item, ProcessingStatePending, nil)
 		}),
 		Priority:           priority,
 		SimNumber:          simNumber,

internal/sms-gateway/modules/messages/repository.go

@@ -13,7 +13,7 @@ import (
 
 const maxPendingBatch = 100
 
-var ErrMessageNotFound = gorm.ErrRecordNotFound
+var ErrMessageNotFound = errors.New("message not found")
 var ErrMessageAlreadyExists = errors.New("duplicate id")
 var ErrMultipleMessagesFound = errors.New("multiple messages found")
 

internal/sms-gateway/modules/sse/service.go

@@ -150,7 +150,7 @@ func (s *Service) handleStream(deviceID string, w *bufio.Writer) {
 			success := true
 			s.metrics.ObserveEventDeliveryLatency(func() {
 				if err := s.writeToStream(w, fmt.Sprintf("event: %s\ndata: %s", event.name, utils.UnsafeString(event.data))); err != nil {
-					s.logger.Warn("Failed to write event data",
+					s.logger.Warn("failed to write event data",
 						zap.String("device_id", deviceID),
 						zap.String("connection_id", conn.id),
 						zap.Error(err))
@@ -164,7 +164,7 @@ func (s *Service) handleStream(deviceID string, w *bufio.Writer) {
 		// Conditionally handle ticker events
 		case <-tickerChan:
 			if err := s.writeToStream(w, ":keepalive"); err != nil {
-				s.logger.Warn("Failed to write keepalive",
+				s.logger.Warn("failed to write keepalive",
 					zap.String("device_id", deviceID),
 					zap.String("connection_id", conn.id),
 					zap.Error(err))

internal/version/version.go

@@ -4,7 +4,7 @@ import "strconv"
 
 const notSet string = "not set"
 
-// these information will be collected when build, by `-ldflags "-X main.appVersion=0.1"`.
+// This information will be collected when build, by `-ldflags "-X main.appVersion=0.1"`.
 //
 //nolint:gochecknoglobals // build-time constant
 var (

pkg/health/service.go

@@ -37,7 +37,7 @@ func (s *Service) checkProvider(
 
 		healthChecks, err := probe(ctx, p)
 		if err != nil {
-			s.logger.Error("Failed check", zap.String("provider", p.Name()), zap.Error(err))
+			s.logger.Error("failed check", zap.String("provider", p.Name()), zap.Error(err))
 			check.Checks[p.Name()] = CheckDetail{
 				Description:   "Failed check",
 				ObservedUnit:  "",