[lint] minor fixes

Author: capcom6

.github/workflows/pr.yml

@@ -12,6 +12,8 @@ jobs:
   e2e:
     name: E2E
     runs-on: ubuntu-latest
+    permissions:
+      contents: read
     steps:
       # step 1: checkout repository code
       - name: Checkout code into workspace directory
@@ -72,6 +74,7 @@ jobs:
         with:
           go-version: stable
 
+      # RELEASE_ID: Days since project inception (2022-06-15)
       - name: Set RELEASE_ID env
         run: echo RELEASE_ID=$(( ($(date +%s) - $(date -d "2022-06-15" +%s)) / 86400 )) >> ${GITHUB_ENV}
 

internal/sms-gateway/handlers/messages/params.go

@@ -30,7 +30,7 @@ func (p *thirdPartyGetQueryParams) Validate() error {
 }
 
 func (p *thirdPartyGetQueryParams) ToFilter() messages.SelectFilter {
-	filter := messages.SelectFilter{}
+	var filter messages.SelectFilter
 
 	if p.StartDate != "" {
 		if t, err := time.Parse(time.RFC3339, p.StartDate); err == nil {
@@ -56,13 +56,14 @@ func (p *thirdPartyGetQueryParams) ToFilter() messages.SelectFilter {
 }
 
 func (p *thirdPartyGetQueryParams) ToOptions() messages.SelectOptions {
-	options := messages.SelectOptions{
-		WithRecipients: true,
-		WithStates:     true,
-	}
+	const maxLimit = 100
+
+	var options messages.SelectOptions
+	options.WithRecipients = true
+	options.WithStates = true
 
 	if p.Limit > 0 {
-		options.Limit = min(p.Limit, 100)
+		options.Limit = min(p.Limit, maxLimit)
 	} else {
 		options.Limit = 50
 	}

internal/sms-gateway/handlers/middlewares/userauth/userauth.go

@@ -92,8 +92,8 @@ func HasUser(c *fiber.Ctx) bool {
 
 // GetUser returns the user stored in the Locals under the key LocalsUser.
 func GetUser(c *fiber.Ctx) *models.User {
-	if user, ok := c.Locals(localsUser).(models.User); ok {
-		return &user
+	if user, ok := c.Locals(localsUser).(*models.User); ok {
+		return user
 	}
 
 	return nil

internal/sms-gateway/handlers/mobile.go

@@ -207,7 +207,7 @@ func (h *mobileHandler) changePassword(device models.Device, c *fiber.Ctx) error
 	req := new(smsgateway.MobileChangePasswordRequest)
 
 	if err := h.BodyParserValidator(c, req); err != nil {
-		return fiber.NewError(fiber.StatusBadGateway, err.Error())
+		return fiber.NewError(fiber.StatusBadRequest, err.Error())
 	}
 
 	if err := h.authSvc.ChangePassword(device.UserID, req.CurrentPassword, req.NewPassword); err != nil {

internal/sms-gateway/handlers/upstream.go

@@ -65,7 +65,7 @@ func (h *upstreamHandler) postPush(c *fiber.Ctx) error {
 
 	for _, v := range req {
 		if err := h.ValidateStruct(v); err != nil {
-			return fiber.NewError(fiber.StatusBadGateway, err.Error())
+			return fiber.NewError(fiber.StatusBadRequest, err.Error())
 		}
 
 		event := push.Event{

internal/sms-gateway/modules/messages/cache.go

@@ -60,7 +60,7 @@ func (c *cache) Get(ctx context.Context, userID, id string) (*MessageStateOut, e
 	}
 
 	if len(data) == 0 {
-		return nil, nil //nolint:nilnil //special meaning
+		return nil, nil //nolint:nilnil //empty cached value is used for caching "Not Found"
 	}
 
 	message := new(MessageStateOut)

internal/sms-gateway/modules/settings/repository.go

@@ -30,7 +30,7 @@ func (r *repository) UpdateSettings(settings *DeviceSettings) (*DeviceSettings,
 	var updatedSettings *DeviceSettings
 	err := r.db.Transaction(func(tx *gorm.DB) error {
 		source := new(DeviceSettings)
-		if err := tx.Clauses(clause.Locking{Strength: clause.LockingStrengthUpdate}).Where("user_id", settings.UserID).Limit(1).Find(source).Error; err != nil {
+		if err := tx.Clauses(clause.Locking{Strength: clause.LockingStrengthUpdate}).Where("user_id = ?", settings.UserID).Limit(1).Find(source).Error; err != nil {
 			return err
 		}