This repository was archived by the owner on Oct 15, 2024. It is now read-only.
Switch new PGP backend to use PGPainless #1522
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
Implements a new crypto backend based on PGPainless, a BouncyCastle-backed, pure-Java library for OpenPGP that irons out a lot of the warts with other PGP libraries and is in active maintenance.
💡 Motivation and Context
While Gopenpgp is great in of itself, it has certain characteristics that make it rather undesirable for us.
PGPainless gets rid of all these problems:
Additionally, it leverages strong typing to entirely prevent multiple bug classes such as using a private and public key interchangeably.
Once this PR is merged I will archive our fork of Gopenpgp.
💚 How did you test it?
Inserted hard-coded credentials and verified decryption/encryption works perfectly.
📝 Checklist
./gradlew spotlessApply
🔮 Next steps