Warnings with webpack.

[hh9527]

WARNING in d:/dws/projects/febs/febs/~/encoding/lib/encoding.js
Critical dependencies:
9:12-34 the request of a dependency is an expression
 @ d:/dws/projects/febs/febs/~/encoding/lib/encoding.js 9:12-34

Related code: https://github.com/andris9/encoding/blob/master/lib/encoding.js#L9

Please dont try to fool webpack, users can use webpack.IgnorePlugin to prevent loading of 'iconv'.

[andris9]

This module is meant for Node only, do not use it with webpack if it doesn't work

[hh9527]

I use this module in node env. With webpack, the server side application can be packaged in one js file with only required source files included.

[andris9]

This behavior with require as an expression is intentional to be able to load iconv in environments where it is supported and fall back to iconv-lite where it is not. Webpack support is not a priority.

[hh9527]

Currently, webpack is ok except the above warning.

But change these 2 lines

    var iconv_package = 'iconv';
    Iconv = require(iconv_package).Iconv;

to

    Iconv = require('iconv').Iconv;

will allow user to avoid the warning.

[andris9]

This change would break browserify which is more used than webpack. I'm willing to change the code to support webpack as well but only if it doesn't break anything existing.

[hh9527]

OK, thank you.

There is a way to do that:

Iconv = require('./iconv-loader');

and

// file: iconv-loader.js
var pkg = 'iconv';
module.exports = require(pkg);

and then, user can use webpack.IgnorePlugin to ignore /\/iconv-loader$/

[andris9]

Updated code to load Iconv as you suggested. Released as v0.1.12

[hh9527]

Thank you!

[silvenon]

Won't this cause an error as soon as it's run with Node? I'm getting this:

Error: Cannot find module "./iconv-loader"

I think it's meant only for requires inside a try...catch block?

[silvenon]

This works:

  module: {
    exprContextRegExp: /$^/,
    exprContextCritical: false,
    loaders: [/*...*/]
  }

It invalidates all require(expr) cases, i.e. this one, just as the Universe intended. Stolen from webpack/webpack#198 (comment).

[jimpick]

IgnorePlugin didn't work for me, when I used it, webpack put in some code that throws an error. I did this instead in plugins:

new webpack.NormalModuleReplacementPlugin(//iconv-loader$/, 'node-noop')

I needed to install the node-noop npm module.

[silvenon]

@jimpick that's much cleaner, thanks 👍