Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] [102] Fix deep diffing issue for obj in array #125

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ProjectBarks
Copy link

@ProjectBarks ProjectBarks commented Apr 3, 2024

Overview
Fixes issue as described in #102

By default array replace was not recursively diffing objects in arrays which would cause them to be reported as complete replacements. Instead, this will recursively diff when the number of replacements equal and score is greater than zero.

Changes

  • Fail out of replacement if change has no shared values
  • Allow for recursive diffing if keys only isn't set
  • Bump version since this could break some peoples output from past expectations

@ProjectBarks
Copy link
Author

@ewoudenberg if you could review :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant