Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add t-SNE to wikirec #35

Open
andrewtavis opened this issue Apr 6, 2021 · 3 comments
Open

Add t-SNE to wikirec #35

andrewtavis opened this issue Apr 6, 2021 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@andrewtavis
Copy link
Owner

It would be helpful to be able to visualize the embeddings created by wikirec models, and one such way to achieve this is t-SNE. This would allow the results models to be visually compared to see how relationships are being derived.

The Python package kwx has an implementation of t-SNE that could be adopted for this package, with another reference being the blogpost that this package was originally based on, which is found here. Ideally this would be put into a visuals.py module, which further would be added to the documentation and tested using pytest's monkeypatch feature (see the tests for kwx for an example). Partial implementations are more than welcome though!

Please first indicate your interest in working on this, as it is a feature implementation :)

Thanks for your interest in contributing!

@andrewtavis andrewtavis added documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed and removed help wanted Extra attention is needed documentation Improvements or additions to documentation labels Apr 6, 2021
@andrewtavis
Copy link
Owner Author

@victle, will write to you about this here :) You'd be welcome to work on this as well if you're interested! I honestly think that the kwx implementation of TFIDF would be good enough to copy over, but then you'd be welcome to look into other resources and make improvements (I'd then use them in kwx no doubt).

A question would be how the package structure would change. In kwx I have kwx.visuals, so would we want to do a wikirec.visuals module? And if so, should graph_lda_topic_evals be moved into there from wikirec.utils?

@victle
Copy link
Contributor

victle commented Apr 17, 2021

I'll try to go through that implementation and get a better understanding first. Any resources you have besides kwx would be appreciated! I like the idea of having a wikirec.visuals module—keeps everything nice and tidy.

@andrewtavis
Copy link
Owner Author

Sounds great :) I just updated the wiki just now with some useful resources on t-SNE 😊

Feel free to split off the module yourself in the PR. Thanks for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants