Skip to content

Commit f7a3ca2

Browse files
committed
fix the corner case of maxmin
1 parent 967d041 commit f7a3ca2

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

mllib/src/main/scala/org/apache/spark/mllib/rdd/VectorRDDFunctions.scala

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -59,16 +59,16 @@ private class Aggregator(
5959

6060
override def max(): Vector = {
6161
nnz.activeIterator.foreach {
62-
case (id, 0.0) => currMax(id) = 0.0
63-
case _ =>
62+
case (id, count) =>
63+
if ((count == 0.0) || ((count < totalCnt) && (currMax(id) < 0.0))) currMax(id) = 0.0
6464
}
6565
Vectors.fromBreeze(currMax)
6666
}
6767

6868
override def min(): Vector = {
6969
nnz.activeIterator.foreach {
70-
case (id, 0.0) => currMin(id) = 0.0
71-
case _ =>
70+
case (id, count) =>
71+
if ((count == 0.0) || ((count < totalCnt) && (currMin(id) > 0.0))) currMin(id) = 0.0
7272
}
7373
Vectors.fromBreeze(currMin)
7474
}

0 commit comments

Comments
 (0)