fix: remove naming conventions for stores and composables in the enforce-naming-convention rule

Author: andrewmolyuk

src/rules/enforce-naming-convention.js

@@ -144,29 +144,12 @@ function validateNamingConvention(filename, componentName) {
     }
 
     case 'store': {
-      // Stores must use 'useXxxStore.ts' pattern
-      if (!basename.startsWith('use') || !basename.includes('Store.')) {
-        const cleanName = nameFromFile.replace(/^use/, '').replace(/Store$/, '')
-        const suggested = `use${toPascalCase(cleanName)}Store.ts`
-        violations.push({
-          type: 'filename',
-          message: `Store files must follow 'useXxxStore.ts' pattern. Expected: ${suggested}`,
-          expected: suggested,
-        })
-      }
+      // No naming requirement for stores
       break
     }
 
     case 'composable': {
-      // Composables must start with 'useXxx.ts'
-      if (!basename.startsWith('use')) {
-        const suggested = `use${toPascalCase(nameFromFile)}.ts`
-        violations.push({
-          type: 'filename',
-          message: `Composable files must start with 'use'. Expected: ${suggested}`,
-          expected: suggested,
-        })
-      }
+      // No naming requirement for composables
       break
     }
 
@@ -292,13 +275,7 @@ export default {
         const fileType = getFileType(filename)
 
         // Validate file naming for all supported file types
-        if (
-          fileType === 'store' ||
-          fileType === 'composable' ||
-          fileType === 'service' ||
-          fileType === 'component' ||
-          fileType === 'view'
-        ) {
+        if (fileType === 'service' || fileType === 'component' || fileType === 'view') {
           const violations = validateNamingConvention(filename, null)
 
           violations.forEach((violation) => {

tests/enforce-naming-convention.spec.js

@@ -163,25 +163,21 @@ describe('vue-modular/enforce-naming-convention rule', () => {
           code: 'export const constants = { API_URL: "test" };',
           filename: '/src/stores/config/constants.ts',
         },
-      ],
-      invalid: [
+        // All store filenames are now valid
         {
           code: 'export default { }',
           filename: '/src/stores/authStore.ts',
-          errors: [{ messageId: 'namingConvention' }],
         },
         {
           code: 'export default { }',
           filename: '/src/stores/useAuth.ts',
-          errors: [{ messageId: 'namingConvention' }],
         },
-        // Direct store files should follow the pattern
         {
           code: 'export default { }',
           filename: '/src/stores/auth.ts',
-          errors: [{ messageId: 'namingConvention' }],
         },
       ],
+      invalid: [],
     })
   })
 
@@ -196,19 +192,17 @@ describe('vue-modular/enforce-naming-convention rule', () => {
           code: 'export default { }',
           filename: '/src/modules/auth/composables/useLogin.ts',
         },
-      ],
-      invalid: [
+        // All composable filenames are now valid
         {
           code: 'export default { }',
           filename: '/src/composables/api.ts',
-          errors: [{ messageId: 'namingConvention' }],
         },
         {
           code: 'export default { }',
           filename: '/src/composables/apiHelper.ts',
-          errors: [{ messageId: 'namingConvention' }],
         },
       ],
+      invalid: [],
     })
   })
 
@@ -259,15 +253,13 @@ describe('vue-modular/enforce-naming-convention rule', () => {
           code: 'export default { }',
           filename: '/src/shared/constants.js',
         },
-      ],
-      invalid: [
-        // But should still detect patterns based on filename in composables directory
+        // Composables with any naming are now valid
         {
           code: 'export default { }',
-          filename: '/src/composables/helper.ts', // Detected as composable without 'use' prefix
-          errors: [{ messageId: 'namingConvention' }],
+          filename: '/src/composables/helper.ts',
         },
       ],
+      invalid: [],
     })
   })
 })