feat: update error messages for cross feature imports and clarify optional features directory in tests

Author: andrewmolyuk

docs/rules/no-cross-feature-imports.md

@@ -74,7 +74,7 @@ Notes:
 
 ## Project Structure
 
-```text
+```
 src/
 ├── features/
 │   ├── user/

src/rules/enforce-feature-exports.js

@@ -45,7 +45,6 @@ export default {
     ],
     defaultOptions: [defaultOptions],
     messages: {
-      missingFeaturesDir: 'Project is missing `{{src}}/{{featuresDir}}` directory. Create features under `{{src}}/{{featuresDir}}`',
       missingIndex: 'Feature `{{feature}}` is missing a public API file (expected one of: {{indexFiles}})',
     },
   },
@@ -76,7 +75,7 @@ export default {
         try {
           const entries = fs.readdirSync(srcDir)
           if (!entries.includes(featuresDirName)) {
-            context.report({ loc: { line: 1, column: 0 }, messageId: 'missingFeaturesDir', data: { src, featuresDir: featuresDirName } })
+            // features directory is optional; do not report an error when absent
             return
           }
 

src/rules/no-cross-feature-imports.js

@@ -33,7 +33,8 @@ export default {
       },
     ],
     messages: {
-      crossFeatureImport: 'Cannot import "{{importPath}}" from outside "{{name}}". Only imports from "{{allowedPath}}" are allowed.',
+      crossFeatureImport:
+        'Cannot import "{{importPath}}" from outside feature "{{featureName}}". Only imports from "{{allowedPath}}" are allowed.',
     },
   },
   create(context) {
@@ -57,7 +58,7 @@ export default {
             context.report({
               node: node.source,
               messageId: 'crossFeatureImport',
-              data: { importPath: source, name: modulePublicName, allowedPath: `@/${modulesDir}/${modulePublicName}` },
+              data: { importPath: source, featureName: modulePublicName, allowedPath: `@/${modulesDir}/${modulePublicName}` },
             })
             return
           }
@@ -70,7 +71,7 @@ export default {
           context.report({
             node: node.source,
             messageId: 'crossFeatureImport',
-            data: { importPath: source, name: featureInfo.featureName, allowedPath: featureInfo.allowedPath },
+            data: { importPath: source, featureName: featureInfo.featureName, allowedPath: featureInfo.allowedPath },
           })
         }
       },

tests/enforce-feature-exports.spec.js

@@ -17,14 +17,14 @@ describe('enforce-feature-exports rule', () => {
     settings: {},
   })
 
-  it('reports when features directory is missing', () => {
+  it('does not report when features directory is missing (features optional)', () => {
     vi.spyOn(fs, 'readdirSync').mockReturnValue(['components', 'main.ts'])
 
     const context = createContext()
     const rule = featureStructureRule.create(context)
     if (rule.Program) rule.Program()
 
-    expect(context.report).toHaveBeenCalledWith(expect.objectContaining({ messageId: 'missingFeaturesDir' }))
+    expect(context.report).not.toHaveBeenCalled()
   })
 
   it('reports features missing index files', () => {