Skip to content

Commit d411de4

Browse files
authored
Add a note on add_assign_mixed to CHANGELOG (arkworks-rs#600)
1 parent e5e3d01 commit d411de4

File tree

2 files changed

+2
-0
lines changed

2 files changed

+2
-0
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,7 @@
7171
- [\#446](https://github.com/arkworks-rs/algebra/pull/446) (`ark-ff`) Add `CyclotomicMultSubgroup` trait and implement it for extension fields
7272
- [\#447](https://github.com/arkworks-rs/algebra/pull/447) (`ark-ec`, `ark-algebra-test-templates`) Rename and refactor group infrastructure, and test infrastructure for fields, groups, and pairings:
7373
- Create new `Group` trait and move some functionality from `ProjectiveCurve` to it.
74+
- Refactor `add_assign_mixed``add_assign` that's polymorphic over its RHS.
7475
- Rename `ProjectiveCurve` to `CurveGroup: Group`.
7576
- Rename some associated types:
7677
- `AffineCurve``Affine`

ec/src/models/short_weierstrass/group.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -330,6 +330,7 @@ impl<P: SWCurveConfig> Neg for Projective<P> {
330330
}
331331

332332
impl<P: SWCurveConfig, T: Borrow<Affine<P>>> AddAssign<T> for Projective<P> {
333+
/// Using http://www.hyperelliptic.org/EFD/g1p/auto-shortw-jacobian-0.html#addition-madd-2007-bl
333334
fn add_assign(&mut self, other: T) {
334335
let other = other.borrow();
335336
if let Some((&other_x, &other_y)) = other.xy() {

0 commit comments

Comments
 (0)