Skip to content

Commit 58bd8fd

Browse files
committed
Merge branch 'v4-dev' of https://github.com/twbs/bootstrap into v4-dev
2 parents c5170db + 3e25ebb commit 58bd8fd

39 files changed

+315
-284
lines changed

.scss-lint.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -153,6 +153,7 @@ linters:
153153
- align-items
154154
- align-self
155155
- justify-content
156+
- order
156157
- float
157158
- width
158159
- min-width

_includes/docs-navbar.html

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<header class="navbar navbar-inverse navbar-expand-md flex-column flex-md-row bd-navbar">
2-
<a class="navbar-brand mr-0 mr-md-2" href="{{ site.baseurl }}/">
2+
<a class="navbar-brand mr-0 mr-md-2" href="{{ site.baseurl }}/" aria-label="Bootstrap">
33
{% include icons/bootstrap.svg width="36" height="36" class="d-block" %}
44
</a>
55

@@ -43,17 +43,17 @@
4343
</li>
4444

4545
<li class="nav-item">
46-
<a class="nav-link p-2" href="{{ site.repo }}" target="_blank">
46+
<a class="nav-link p-2" href="{{ site.repo }}" target="_blank" aria-label="GitHub">
4747
{% include icons/github.svg class="navbar-nav-svg" %}
4848
</a>
4949
</li>
5050
<li class="nav-item">
51-
<a class="nav-link p-2" href="https://twitter.com/{{ site.twitter }}" target="_blank">
51+
<a class="nav-link p-2" href="https://twitter.com/{{ site.twitter }}" target="_blank" aria-label="Twitter">
5252
{% include icons/twitter.svg class="navbar-nav-svg" %}
5353
</a>
5454
</li>
5555
<li class="nav-item">
56-
<a class="nav-link p-2" href="{{ site.slack }}" target="_blank">
56+
<a class="nav-link p-2" href="{{ site.slack }}" target="_blank" aria-label="Slack">
5757
{% include icons/slack.svg class="navbar-nav-svg" %}
5858
</a>
5959
</li>

_includes/icons/bootstrap.svg

Lines changed: 1 addition & 1 deletion
Loading

_includes/icons/github.svg

Lines changed: 1 addition & 1 deletion
Loading

_includes/icons/menu.svg

Lines changed: 1 addition & 1 deletion
Loading

_includes/icons/slack.svg

Lines changed: 1 addition & 1 deletion
Loading

_includes/icons/twitter.svg

Lines changed: 1 addition & 1 deletion
Loading

_layouts/docs.html

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -17,18 +17,19 @@
1717
<div class="col-12 col-md-3 col-xl-2 bd-sidebar">
1818
{% include docs-sidebar.html %}
1919
</div>
20-
<main class="col-12 col-md-9 col-xl-8 py-md-3 pl-md-5 bd-content" role="main">
21-
<h1 class="bd-title" id="content">{{ page.title }}</h1>
22-
<p class="bd-lead">{{ page.description }}</p>
23-
{% include ads.html %}
24-
{{ content }}
25-
</main>
2620

2721
{% if page.toc %}
2822
<div class="d-none d-xl-block col-xl-2 bd-toc">
2923
{{ content | toc_only }}
3024
</div>
3125
{% endif %}
26+
27+
<main class="col-12 col-md-9 col-xl-8 py-md-3 pl-md-5 bd-content" role="main">
28+
<h1 class="bd-title" id="content">{{ page.title }}</h1>
29+
<p class="bd-lead">{{ page.description }}</p>
30+
{% include ads.html %}
31+
{{ content }}
32+
</main>
3233
</div>
3334
</div>
3435

assets/scss/_content.scss

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@
55
//
66

77
.bd-content {
8+
order: 1;
9+
810
// Hack the sticky header
911
> h2[id],
1012
> h3[id],

assets/scss/_nav.scss

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
// scss-lint:disable VendorPrefix
2-
31
//
42
// Main navbar
53
//
@@ -30,10 +28,11 @@
3028
}
3129

3230
@include media-breakpoint-up(md) {
33-
position: -webkit-sticky;
34-
position: sticky;
35-
top: 0;
36-
z-index: 1071; // over everything in bootstrap
31+
@supports (position: sticky) {
32+
position: sticky;
33+
top: 0;
34+
z-index: 1071; // over everything in bootstrap
35+
}
3736
}
3837

3938
.navbar-nav {

0 commit comments

Comments
 (0)