Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not saving best model #21

Open
andreped opened this issue Aug 20, 2022 · 1 comment
Open

Not saving best model #21

andreped opened this issue Aug 20, 2022 · 1 comment
Labels
bug Something isn't working enhancement New feature or request

Comments

@andreped
Copy link
Owner

The current checkpoint callback saves a model at a given step periodically. However, it is not necessarily the best model.

We should use the EvalCallback: https://stable-baselines3.readthedocs.io/en/master/guide/callbacks.html#evalcallback

@andreped andreped added bug Something isn't working enhancement New feature or request labels Aug 20, 2022
@andreped andreped assigned andreped and unassigned andreped Aug 20, 2022
@andreped
Copy link
Owner Author

andreped commented Apr 4, 2023

This was added here, but it fails due to issue #3.

As training occationally crash and we are unable to properly update the environment, forcing us to completely restart training, the EvalCallback will have the wrong behaviour.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
Status: No status
Development

No branches or pull requests

1 participant