Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fail when no style is explicitly configured (don't use the default style) #606

Merged
merged 2 commits into from
Aug 19, 2023
Merged

fix: fail when no style is explicitly configured (don't use the default style) #606

merged 2 commits into from
Aug 19, 2023

Conversation

andreoliwa
Copy link
Owner

@andreoliwa andreoliwa commented Aug 19, 2023 •
edited
Loading

Issues fixed by this pull request:
Fix #491

Proposed changes

  1. Fail when no style is explicitly configured.
  2. Suggest to run nitpick init or do it manually.

Checklist

  • Read the contribution guidelines
  • Run make locally before pushing commits
  • Add tests for the relevant parts:
    • API
    • CLI
    • flake8 plugin (normal mode)
    • flake8 plugin (offline mode)
  • Write documentation when there's a new API or functionality

@coveralls
Copy link

coveralls commented Aug 19, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 5912450428

  • 6 of 6 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 96.329%
Totals Coverage Status
Change from base Build 5909458222: 0.003%
Covered Lines: 1994
Relevant Lines: 2053
💛 - Coveralls

@andreoliwa andreoliwa marked this pull request as ready for review August 19, 2023 16:38
@andreoliwa andreoliwa changed the title fix: fail when no style is configured, don't use a default style fix: fail when no style is explicitly configured (don't use the default style) Aug 19, 2023
@andreoliwa andreoliwa merged commit f309354 into develop Aug 19, 2023
21 checks passed
@andreoliwa andreoliwa deleted the fail-with-no-style branch August 19, 2023 16:40
github-actions bot pushed a commit that referenced this pull request Dec 31, 2023
@semantic-release-bot
chore(release): 0.35.0 [skip ci]
36d4912 
# [0.35.0](v0.34.0...v0.35.0) (2023-12-31)

### Bug Fixes

* **deps:** update dependency click to v8.1.7 ([783741d](783741d))
* fail when no style is explicitly configured (don't use the default style) ([#606](#606)) ([f309354](f309354))
* **style:** better .editorconfig ([0b779d9](0b779d9))
* **style:** comma_separated_values for flake8/isort ([7336dbc](7336dbc))
* **style:** move "build" to readthedocs.toml ([676ac24](676ac24))
* **style:** remove Radon from the Nitpick preset ([126b1c1](126b1c1))
* **style:** tag markdownlint.toml as a markdown style ([578bfb5](578bfb5))
* **style:** use black mirror that's 2x faster ([67dc163](67dc163))

### Features

* add Python 3.12 ([#616](#616)) ([90ced4c](90ced4c))
* set CLI options with environment variables ([3575b9a](3575b9a))
* **style:** add toml-sort ([#626](#626)) ([a4aeef7](a4aeef7))
* **style:** default Python version on pre-commit ([3557c1f](3557c1f))
* **style:** Poetry (virtualenv in project) ([f002b8b](f002b8b))
* suggest styles based on the file types in the project ([#629](#629)) ([e2bca24](e2bca24))
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 0.35.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released Feature/fix is released label Dec 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released Feature/fix is released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nitpick should fail when no style is explicitly configured
2 participants
@andreoliwa @coveralls