Skip to content

Commit dd996b2

Browse files
committed
Performance improvements - eliminating React to JSON and JSON to React conversions. Using React native structures only.
1 parent f1aa007 commit dd996b2

File tree

2 files changed

+125
-188
lines changed

2 files changed

+125
-188
lines changed

src/android/src/main/java/org/pgsqlite/CallbackContext.java

Lines changed: 7 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,6 @@
99
import com.facebook.react.bridge.WritableArray;
1010
import com.facebook.react.bridge.WritableMap;
1111

12-
import org.json.JSONArray;
13-
import org.json.JSONException;
14-
import org.json.JSONObject;
15-
1612
public class CallbackContext {
1713

1814
private static final String LOG_TAG = CallbackContext.class.getSimpleName();
@@ -30,13 +26,9 @@ public CallbackContext(Callback success, Callback error) {
3026
*
3127
* @param message The message to add to the success result.
3228
*/
33-
public void success(JSONObject message) {
34-
try {
35-
WritableMap writableMap = SQLitePluginConverter.jsonToReact(message);
36-
successCallback.invoke(writableMap);
37-
} catch (JSONException ex){
38-
errorCallback.invoke("Internal error converting results:"+ex.getMessage());
39-
}
29+
public void success(WritableMap message) {
30+
successCallback.invoke(message);
31+
4032
}
4133

4234
/**
@@ -53,14 +45,8 @@ public void success(String message) {
5345
*
5446
* @param message The message to add to the success result.
5547
*/
56-
public void success(JSONArray message) {
57-
try {
58-
WritableArray writableArray = SQLitePluginConverter.jsonToReact(message);
59-
successCallback.invoke(writableArray);
60-
} catch (JSONException ex){
61-
errorCallback.invoke("Internal error converting results:"+ex.getMessage());
62-
}
63-
48+
public void success(WritableArray message) {
49+
successCallback.invoke(message);
6450
}
6551

6652
/**
@@ -75,13 +61,8 @@ public void success() {
7561
*
7662
* @param message The message to add to the error result.
7763
*/
78-
public void error(JSONObject message) {
79-
try {
80-
WritableMap writableMap = SQLitePluginConverter.jsonToReact(message);
81-
errorCallback.invoke(writableMap);
82-
} catch (JSONException ex){
83-
errorCallback.invoke("Internal error converting results:"+ex.getMessage());
84-
}
64+
public void error(WritableMap message) {
65+
errorCallback.invoke(message);
8566
}
8667

8768
/**

0 commit comments

Comments
 (0)