Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use matplotlib more transparently #26

Open
clbarnes opened this issue Apr 4, 2019 · 0 comments
Open

Use matplotlib more transparently #26

clbarnes opened this issue Apr 4, 2019 · 0 comments

Comments

@clbarnes
Copy link

clbarnes commented Apr 4, 2019

Matplotlib gives us a lot of flexibility in terms of plot sizes, aspect ratios, adding annotations, styling, and so on: all of which are valuable to people creating sankey diagrams. Currently, the sankey function uses a number of extra keyword arguments to ape a tiny portion of that flexibility, making it harder to read and maintain, while taking a lot of valuable power away from the user (see #22 , #19, #7).

sankey could, instead, take a matplotlib Axes object, which the user can customise to their liking, and where the user also has access to the Figure to customise. Then they can choose what to do with it - showing it, saving it with much more flexibility.

pySankey's maintainability would improve as it's doing less; users would have a lot more power.

P.S. pySankey is great! So much more usable than floweaver.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant