Skip to content

Commit 5425325

Browse files
anamnavianamnavi
committed
fixed pylint errors, rpc_m_c
1 parent e182e37 commit 5425325

2 files changed

Lines changed: 109 additions & 89 deletions

File tree

‎opencensus/trace/measure.py‎

Lines changed: 1 addition & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -47,27 +47,4 @@ def description(self):
4747
@property
4848
def unit(self):
4949
return self._unit
50-
#
51-
# def get_name(self):
52-
# """
53-
# returns the name of the measurement
54-
# """
55-
# return self.name
56-
#
57-
# def get_description(self):
58-
# """
59-
# returns the description of the measurement
60-
# """
61-
# return self.description
62-
#
63-
# def get_unit(self):
64-
# """
65-
# returns the unit of the measurement
66-
# """
67-
# return self.unit
68-
#
69-
# def match(self):
70-
# """
71-
# was applying a function (pointer) based on whether it was measure_long, measure_double
72-
# todo: decide if needs to be implemented
73-
# """
50+

‎opencensus/trace/rpc_measure_constants.py‎

Lines changed: 108 additions & 65 deletions
Original file line numberDiff line numberDiff line change
@@ -21,81 +21,124 @@ def __init__(self):
2121
# gRPC server status code received, e.g. OK, CANCELLED, DEADLINE_EXCEEDED
2222
self.grpc_client_status = tag_key.TagKey("grpc_client_status")
2323

24-
# Full gRPC method name, including package, service and method, e.g. google.bigtable.v2.Bigtable/CheckAndMutateRow
24+
# Full gRPC method name, including package, service and method,
25+
# e.g. google.bigtable.v2.Bigtable/CheckAndMutateRow
2526
self.grpc_client_method = tag_key.TagKey("grpc_client_method")
2627

2728
# server tags
2829

2930
# gRPC server status code returned, e.g. OK, CANCELLED, DEADLINE_EXCEEDED
3031
self.grpc_server_status = tag_key.TagKey("grpc_server_status")
3132

32-
# Full gRPC method name, including package, service and method, e.g. com.exampleapi.v4.BookshelfService/Checkout
33+
# Full gRPC method name, including package, service and method,
34+
# e.g. com.exampleapi.v4.BookshelfService/Checkout
3335
self.grpc_server_method = tag_key.TagKey("grpc_server_method")
3436

3537

3638
# client measures
37-
self.grpc_client_sent_messages_per_rpc = measure.Measure("grpc.io/client/sent_messages_per_rpc",
38-
"Number of messages sent in the RPC",
39-
self.count)
40-
self.grpc_client_sent_bytes_per_rpc = measure.Measure("grpc.io/client/sent_bytes_per_rpc",
41-
"Total bytes sent across all request messages per RPC",
42-
self.byte)
43-
self.grpc_client_received_messages_per_rpc = measure.Measure("grpc.io/client/received_messages_per_rpc",
44-
"Number of response messages received per RPC",
45-
self.count)
46-
self.grpc_client_received_bytes_per_rpc = measure.Measure("grpc.io/client/received_bytes_per_rpc",
47-
"Total bytes received across all response messages per RPC",
48-
self.byte)
49-
self.grpc_client_roundtrip_latency = measure.Measure("grpc.io/client/roundtrip_latency",
50-
"Time between first byte of request sent to last byte of response received or terminal error.",
51-
self.millisecond)
52-
self.grpc_client_server_latency = measure.Measure("grpc.io/client/server_latency",
53-
"Server latency in msecs",
54-
self.millisecond)
55-
self.grpc_client_started_rpcs = measure.Measure("grpc.io/client/started_rpcs",
56-
"Number of started client RPCs.",
57-
self.count)
58-
self.grpc_client_sent_messages_per_method = measure.Measure("grpc.io/client/sent_messages_per_method",
59-
"Total messages sent per method.",
60-
self.count)
61-
self.grpc_client_received_messages_per_method = measure.Measure("grpc.io/client/received_messages_per_method",
62-
"Total messages received per method.",
63-
self.count)
64-
self.grpc_client_sent_bytes_per_method = measure.Measure("grpc.io/client/sent_bytes_per_method",
65-
"Total bytes sent per method, recorded real-time as bytes are sent.",
66-
self.byte)
67-
self.grpc_client_received_bytes_per_method = measure.Measure("grpc.io/client/received_bytes_per_method",
68-
"Total bytes received per method, recorded real-time as bytes are received.",
69-
self.byte)
39+
self.grpc_client_sent_messages_per_rpc = measure.Measure(
40+
name="grpc.io/client/sent_messages_per_rpc",
41+
description="Number of messages sent in the RPC",
42+
unit=self.count)
43+
44+
self.grpc_client_sent_bytes_per_rpc = measure.Measure(
45+
name="grpc.io/client/sent_bytes_per_rpc",
46+
description="Total bytes sent across all request messages per RPC",
47+
unit=self.byte)
48+
49+
self.grpc_client_received_messages_per_rpc = measure.Measure(
50+
name="grpc.io/client/received_messages_per_rpc",
51+
description="Number of response messages received per RPC",
52+
unit=self.count)
53+
54+
self.grpc_client_received_bytes_per_rpc = measure.Measure(
55+
name="grpc.io/client/received_bytes_per_rpc",
56+
description="Total bytes received across all response messages per RPC",
57+
unit=self.byte)
58+
59+
self.grpc_client_roundtrip_latency = measure.Measure(
60+
name="grpc.io/client/roundtrip_latency",
61+
description="Time between first byte of request sent to"
62+
" last byte of response received or terminal error.",
63+
unit=self.millisecond)
64+
65+
self.grpc_client_server_latency = measure.Measure(
66+
name="grpc.io/client/server_latency",
67+
description="Server latency in msecs",
68+
unit=self.millisecond)
69+
70+
self.grpc_client_started_rpcs = measure.Measure(
71+
name="grpc.io/client/started_rpcs",
72+
description="Number of started client RPCs.",
73+
unit=self.count)
74+
75+
self.grpc_client_sent_messages_per_method = measure.Measure(
76+
name="grpc.io/client/sent_messages_per_method",
77+
description="Total messages sent per method.",
78+
unit=self.count)
79+
80+
self.grpc_client_received_messages_per_method = measure.Measure(
81+
name="grpc.io/client/received_messages_per_method",
82+
description="Total messages received per method.",
83+
unit=self.count)
84+
85+
self.grpc_client_sent_bytes_per_method = measure.Measure(
86+
name="grpc.io/client/sent_bytes_per_method",
87+
description="Total bytes sent per method, recorded real-time as bytes are sent.",
88+
unit=self.byte)
89+
90+
self.grpc_client_received_bytes_per_method = measure.Measure(
91+
name="grpc.io/client/received_bytes_per_method",
92+
description="Total bytes received per method,"
93+
" recorded real-time as bytes are received.",
94+
unit=self.byte)
7095

7196
# server measures
72-
self.grpc_server_received_messages_per_rpc = measure.Measure("grpc.io/server/received_messages_per_rpc",
73-
"Number of messages received in each RPC",
74-
self.count)
75-
self.grpc_server_received_bytes_per_rpc = measure.Measure("grpc.io/server/received_bytes_per_rpc",
76-
"Total bytes received across all messages per RPC",
77-
self.byte)
78-
self.grpc_server_sent_messages_per_rpc = measure.Measure("grpc.io/server/sent_messages_per_rpc",
79-
"Number of messages sent in each RPC",
80-
self.count)
81-
self.grpc_server_sent_bytes_per_rpc = measure.Measure("grpc.io/server/sent_bytes_per_rpc",
82-
"Total bytes sent across all response messages per RPC",
83-
self.byte)
84-
self.grpc_server_server_latency = measure.Measure("grpc.io/server/server_latency",
85-
"Time between first byte of request received to last byte of response sent or terminal error.",
86-
self.millisecond)
87-
self.grpc_server_started_rpcs = measure.Measure("grpc.io/server/started_rpcs",
88-
"Number of started server RPCs.",
89-
self.count)
90-
self.grpc_server_sent_messages_per_method = measure.Measure("grpc.io/server/sent_messages_per_method",
91-
"Total messages sent per method.",
92-
self.count)
93-
self.grpc_server_received_messages_per_method = measure.Measure("grpc.io/server/received_messages_per_method",
94-
"Total messages received per method.",
95-
self.count)
96-
self.grpc_server_sent_bytes_per_method = measure.Measure("grpc.io/server/sent_bytes_per_method",
97-
"Total bytes sent per method, recorded real-time as bytes are sent.",
98-
self.byte)
99-
self.grpc_server_received_bytes_per_method = measure.Measure("grpc.io/server/received_bytes_per_method",
100-
"Total bytes received per method, recorded real-time as bytes are received.",
101-
self.byte)
97+
self.grpc_server_received_messages_per_rpc = measure.Measure(
98+
name="grpc.io/server/received_messages_per_rpc",
99+
description="Number of messages received in each RPC",
100+
unit=self.count)
101+
self.grpc_server_received_bytes_per_rpc = measure.Measure(
102+
name="grpc.io/server/received_bytes_per_rpc",
103+
description="Total bytes received across all messages per RPC",
104+
unit=self.byte)
105+
106+
self.grpc_server_sent_messages_per_rpc = measure.Measure(
107+
name="grpc.io/server/sent_messages_per_rpc",
108+
description="Number of messages sent in each RPC",
109+
unit=self.count)
110+
111+
self.grpc_server_sent_bytes_per_rpc = measure.Measure(
112+
name="grpc.io/server/sent_bytes_per_rpc",
113+
description="Total bytes sent across all response messages per RPC",
114+
unit=self.byte)
115+
self.grpc_server_server_latency = measure.Measure(
116+
name="grpc.io/server/server_latency",
117+
description="Time between first byte of request received"
118+
" to last byte of response sent or terminal error.",
119+
unit=self.millisecond)
120+
121+
self.grpc_server_started_rpcs = measure.Measure(
122+
name="grpc.io/server/started_rpcs",
123+
description="Number of started server RPCs.",
124+
unit=self.count)
125+
126+
self.grpc_server_sent_messages_per_method = measure.Measure(
127+
name="grpc.io/server/sent_messages_per_method",
128+
description="Total messages sent per method.",
129+
unit=self.count)
130+
131+
self.grpc_server_received_messages_per_method = measure.Measure(
132+
name="grpc.io/server/received_messages_per_method",
133+
description="Total messages received per method.",
134+
unit=self.count)
135+
136+
self.grpc_server_sent_bytes_per_method = measure.Measure(
137+
name="grpc.io/server/sent_bytes_per_method",
138+
description="Total bytes sent per method, recorded real-time as bytes are sent.",
139+
unit=self.byte)
140+
141+
self.grpc_server_received_bytes_per_method = measure.Measure(
142+
name="grpc.io/server/received_bytes_per_method",
143+
description="Total bytes received per method, recorded real-time as bytes are received.",
144+
unit=self.byte)

0 commit comments

Comments
 (0)