drivers: meter: ade9153a : Add README documentation for ADE9153a #2563
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mc-so <michelleclaire.so@analog.com> This adds the rst readme document for the ADE9153a driver. Also modified the sphinx driver doc to add the corresponding source for this new readme.
mc-so
requested review from
buha,
CiprianRegus,
dbogdan,
amiclaus,
rbolboac and
danmois
as code owners
|
|
buha
reviewed
Apr 23, 2025
| return ret; | ||
| } | ||
|
|
||
|
|
There was a problem hiding this comment.
the lines from here down shouldn't be here
buha
reviewed
Apr 23, 2025
| int main() | ||
| { | ||
| struct ade9153a_dev *ade9153a_dev; | ||
| struct ade9153a_init_param ade9153a_ip; |
There was a problem hiding this comment.
initialize ade9153a_ip with actual values
buha
reviewed
Apr 23, 2025
| // Burst mode disable | ||
| ade9153a_dev->burst_en = 0; | ||
|
|
||
| no_os_mdelay(RESET_TIME); |
buha
reviewed
Apr 23, 2025
| goto free_dev; | ||
|
|
||
| // Burst mode disable | ||
| ade9153a_dev->burst_en = 0; |
There was a problem hiding this comment.
this is bad in my opinion, maybe the driver needs to be modified, the user shouldn't need to modify descriptor members like this, but through the driver API
buha
reviewed
Apr 23, 2025
|
|
||
| while (1) { | ||
| // Time delay between readings | ||
| no_os_mdelay(READ_INTERVAL); |
buha
requested changes
Apr 23, 2025
| remove_uart: | ||
| no_os_uart_remove(uart_desc); | ||
| remove_irq: | ||
| no_os_irq_ctrl_remove(ade9153a_nvic_desc); |
There was a problem hiding this comment.
i am not sure what's with all these remove calls here, only remove what you initialize
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: mc-so michelleclaire.so@analog.com
This adds the rst readme document for the ADE9153a driver.
Also modified the sphinx driver doc to add the corresponding source for this new readme.
PR Type
PR Checklist