library/util_axis_fifo_asym: fix internal fifo #1907
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The internal i_fifo is relying on the default value for the REMOVE_NULL_BEAT_EN, which is disabled. Signals full, empty, almost full, almost empty will only work when this parameter is disabled. Otherwise, it would be necessary to define a new policy to define how that is presented to the user. This commit forces REMOVE_NULL_BEAT_EN to be disabled in its i_fifo instance. Signed-off-by: Carlos Souza <carlos.souza@analog.com>
caosjr
requested review from
AndreiGrozav,
PopPaul2021,
acostina,
gastmaier and
sarpadi
as code owners
gastmaier
approved these changes
Sep 9, 2025
Contributor
gastmaier
left a comment
gastmaier
left a comment
There was a problem hiding this comment.
This pr fully instantiates the parameters in the module to not rely in the default value, instead, propagate one layer above.
IstvanZsSzekely
approved these changes
Sep 10, 2025
caosjr
added a commit
that referenced
this pull request
Sep 17, 2025
The internal i_fifo is relying on the default value for the REMOVE_NULL_BEAT_EN, which is disabled. Signals full, empty, almost full, almost empty will only work when this parameter is disabled. Otherwise, it would be necessary to define a new policy to define how that is presented to the user. This commit forces REMOVE_NULL_BEAT_EN to be disabled in its i_fifo instance. Signed-off-by: Carlos Souza <carlos.souza@analog.com>
StancaPop
pushed a commit
that referenced
this pull request
Oct 20, 2025
The internal i_fifo is relying on the default value for the REMOVE_NULL_BEAT_EN, which is disabled. Signals full, empty, almost full, almost empty will only work when this parameter is disabled. Otherwise, it would be necessary to define a new policy to define how that is presented to the user. This commit forces REMOVE_NULL_BEAT_EN to be disabled in its i_fifo instance. Signed-off-by: Carlos Souza <carlos.souza@analog.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The internal i_fifo is relying on the default value for the REMOVE_NULL_BEAT_EN, which is disabled. Signals full, empty, almost full, almost empty will only work when this parameter is disabled.
Otherwise, it would be necessary to define a new policy to define how that is presented to the user.
This commit forces REMOVE_NULL_BEAT_EN to be disabled in its i_fifo instance.
PR Type
PR Checklist