Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace f.js with twitter.js for 3p iframe #35352

Merged
merged 1 commit into from
Jul 23, 2021
Merged

Replace f.js with twitter.js for 3p iframe #35352

merged 1 commit into from
Jul 23, 2021

Conversation

powerivq
Copy link
Contributor

@powerivq powerivq commented Jul 22, 2021 •
edited
Loading

We are trying to deprecate f.js (#35349), in favor of vendor-specific js for better performance. PTAL

@powerivq powerivq requested a review from caroqliu July 22, 2021 06:37
@powerivq powerivq enabled auto-merge (squash) July 22, 2021 20:32
@powerivq powerivq merged commit ec65363 into ampproject:main Jul 23, 2021
@powerivq powerivq deleted the twtr-remove-fjs branch July 23, 2021 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caroqliu caroqliu caroqliu approved these changes

Assignees
No one assigned
Labels
PR use: In Beta / Experimental PR use: In Stable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@powerivq @caroqliu @ampprojectbot