Add deprecation notice to 3p iframe f.js #35350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calebcordry
reviewed
Jul 23, 2021
3p/integration.js
Outdated
| @@ -311,6 +312,11 @@ import {zen} from '#ads/vendors/zen'; | |||
| import {zergnet} from '#ads/vendors/zergnet'; | |||
| import {zucks} from '#ads/vendors/zucks'; | |||
|
|
|||
| user().error( | |||
There was a problem hiding this comment.
I think this will halt execution, is that what we want?
There was a problem hiding this comment.
https://github.com/ampproject/amphtml/blob/main/src/log.js#L315 user().error shouldn't throw. user().assert will. But you reminded me that this will trigger log entry, and might overstress AMP logging system. Changing to warn only.
powerivq
force-pushed
the
remove-integration-1
branch
from
785d886
to
6b69121
Compare
calebcordry
approved these changes
Jul 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the first step of #35349, we send out deprecation notice to those using f.js