Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Json fix #26971

Merged
merged 5 commits into from
Feb 26, 2020
Merged

Json fix #26971

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
14b79fa
change reject to user().createError()
jpettitt Feb 25, 2020
e5628ba
lint
jpettitt Feb 25, 2020
13c3dd8
Update extensions/amp-subscriptions/0.1/amp-subscriptions.js
jpettitt Feb 25, 2020
8710fa9
Update extensions/amp-subscriptions/0.1/amp-subscriptions.js
jpettitt Feb 25, 2020
ed271f5
lint
jpettitt Feb 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
change reject to user().createError()
  • Loading branch information
@jpettitt
jpettitt committed Feb 25, 2020
commit 14b79fac052ec4c6ffa3094e6c6c25648dc65d8f
4 changes: 3 additions & 1 deletion extensions/amp-subscriptions/0.1/amp-subscriptions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,9 @@ export class SubscriptionService {
getPlatformConfig_() {
return new Promise((resolve, reject) => {
const rawContent = tryParseJson(this.configElement_.textContent, e => {
reject('Failed to parse "amp-subscriptions" JSON: ' + e);
throw user().createError(
'Failed to parse "amp-subscriptions" JSON: ' + e
);
});
resolve(rawContent);
});
Expand Down