Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀 Remove amp-truncate-text experiment check #26720

Merged
merged 2 commits into from
Feb 11, 2020
Merged

🚀 Remove amp-truncate-text experiment check #26720

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
492409a
🚀 Remove amp-truncate-text experiment check
alanorozco Feb 10, 2020
d216db9
Remove test setup
alanorozco Feb 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
🚀 Remove amp-truncate-text experiment check
  • Loading branch information
@alanorozco
alanorozco committed Feb 10, 2020
commit 492409a2f0687cfb18dc5be67116f6ac92048082
8 changes: 1 addition & 7 deletions extensions/amp-truncate-text/0.1/amp-truncate-text.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ import {
iterateCursor,
} from '../../../src/dom';
import {createShadowRoot} from './shadow-utils';
import {dev, userAssert} from '../../../src/log';
import {dev} from '../../../src/log';
import {htmlFor} from '../../../src/static-template';
import {isExperimentOn} from '../../../src/experiments';
import {toArray} from '../../../src/types';
Expand Down Expand Up @@ -81,12 +81,6 @@ export class AmpTruncateText extends AMP.BaseElement {

/** @override */
buildCallback() {
userAssert(
isExperimentOn(this.win, 'amp-truncate-text'),
'The amp-truncate-text experiment must be enabled to use this ' +
'component.'
);

this.useShadow_ =
!!this.element.attachShadow &&
isExperimentOn(this.win, 'amp-truncate-text-shadow');
Expand Down