🐛 amp-auto-lightbox: Ignore unlaid out elements #26573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enriqe
approved these changes
Feb 3, 2020
| @@ -399,6 +399,11 @@ export function apply(ampdoc, element) { | |||
| export function runCandidates(ampdoc, candidates) { | |||
| return candidates.map(candidate => | |||
| whenLoaded(candidate).then(() => { | |||
| // <amp-img> will change the img's src inline data on unlayout and remove | |||
| // it from DOM, but a LOAD_END event would still be triggered afterwards. | |||
| if (candidate.signals().get(CommonSignals.UNLOAD)) { | |||
There was a problem hiding this comment.
nit: should we move this check to Criteria.meetsAll() to make this method easier to read?
There was a problem hiding this comment.
Not sure it makes sense for it to be in that unit particularly since it would be have to be mocked in tests.
whenLoaded would make more sense, but I don't want to create superfluous wrapping promises for something that runs as many times as something as an amp-img appears on every page :(
ampprojectbot
added
PR use: In Beta / Experimental
and removed
PR use: In Beta / Experimental
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #25764