Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 Specify how amp-video-iframe can be used by video vendors #25952

Merged
merged 8 commits into from
Dec 9, 2019

Conversation

alanorozco
Copy link
Member

A common problem is that new custom players are submitted when they're not required, as amp-video-iframe would be enough.

This clarifies how video vendors can take advantage of amp-video-iframe to let AMP authors embed video provided via their service.

A common problem is that new custom players are submitted when they're not required, as amp-video-iframe would be enough.

This clarifies how video vendors can take advantage of amp-video-iframe to let AMP authors embed video provided via their service.
@alanorozco alanorozco changed the title Video iframe vendor 📖 Specify how amp-video-iframe can be used by video vendors Dec 9, 2019
Copy link
Contributor

@CrystalOnScript CrystalOnScript left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, lgtm! jus two nits

Copy link
Contributor

@kristoferbaxter kristoferbaxter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with nits. Looks good!

@alanorozco alanorozco merged commit 2582dd5 into master Dec 9, 2019
micajuine-ho pushed a commit to micajuine-ho/amphtml that referenced this pull request Dec 27, 2019
…ct#25952)

A common problem is that new custom players are submitted when they're not required, as amp-video-iframe would be enough.

This clarifies how video vendors can take advantage of amp-video-iframe to let AMP authors embed video provided via their service.
@rsimha rsimha deleted the video-iframe-vendor branch February 13, 2020 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants