Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 Clarify readymade amp-video-iframe integration APIs #25410

Merged
merged 11 commits into from
Nov 4, 2019
Merged

📖 Clarify readymade amp-video-iframe integration APIs #25410

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
d978613
📖 Clarify readymade amp-video-iframe integration APIs
alanorozco Nov 4, 2019
71afd9f
Update amp-video-iframe.md
alanorozco Nov 4, 2019
3430d7d
Update amp-video-iframe.md
alanorozco Nov 4, 2019
d3d0933
Update amp-video-iframe.md
alanorozco Nov 4, 2019
573c361
Typo, document video.js initializer
alanorozco Nov 4, 2019
eeff70d
Update amp-video-iframe.md
alanorozco Nov 4, 2019
d4e8744
theeeeeese
alanorozco Nov 4, 2019
16f7ced
Update amp-video-iframe.md
alanorozco Nov 4, 2019
a1c4b19
Update amp-video-iframe.md
alanorozco Nov 4, 2019
2fd99bc
Update amp-video-iframe.md
alanorozco Nov 4, 2019
60b161a
Update amp-video-iframe.md
alanorozco Nov 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update amp-video-iframe.md
  • Loading branch information
@alanorozco
alanorozco authored Nov 4, 2019
commit 60b161a499ea5d455b3bcce4d95b24c28681391c
2 changes: 1 addition & 1 deletion extensions/amp-video-iframe/amp-video-iframe.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,7 @@ function onAmpIntegrationReady(ampIntegration) {
```js
function onAmpIntegrationReady(ampIntegration) {
var myVideo = document.querySelector('#my-video');

// ampIntegration initializes player with `myVideojsInitializer(myVideo)`
ampIntegration.listenTo('videojs', myVideo, myVideojsInitializer);
}
Expand Down