-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖Fix typo in AMP Variable Substitutions documentation #24818
Conversation
<amp-pixel> was missing ">" on its opening tag.
CC @ampproject/wg-outreach |
Thanks for the fix! |
Anything delaying merge on this one? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding a review comment to restart the owners bot!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh and approving since it needs a Reviewer approval.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test comment
The owners bot is WAI. This PR does not have owners approval ( |
Once #25075 goes in, @CrystalOnScript's approval will count as an OWNER approval, so it should be ready to merge. Thanks for your patience as we work through some of the last issues with the Owners/Reviewers checks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rerun owners
Woo! It looks like it's ready to merge now. @mattwomple use your powers! |
Thanks @mrjoro but I don't think Collaborators actually have write access. I still see "The base branch restricts merging to authorized users." and the email from github reads:
|
OK, I think it should (hopefully) work now... there was one more setting we needed to adjust. :) If it still doesn't work, we may need to wait for the permissions to propagate. But let's see... |
I love the entire sequence of events in this PR! Glad to have you as a collaborator, @mattwomple! |
<amp-pixel> was missing ">" on its opening tag.
<amp-pixel> was missing ">" on its opening tag.
<amp-pixel> was missing > on its opening tag.