Actually cache on Travis push builds #24239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cramforce
reviewed
Aug 27, 2019
.travis.yml
Outdated
| # do not store cache for PR builds | ||
| - if [[ $TRAVIS_PULL_REQUEST ]]; then exit $TRAVIS_TEST_RESULT ; fi | ||
| # do not store cache for non-push builds | ||
| - if [[ $TRAVIS_EVENT_TYPE != push ]]; then exit $TRAVIS_TEST_RESULT ; fi |
There was a problem hiding this comment.
Checked by changing it to $TRAVIS_EVENT_TYPE == pull_request. Works without quotes
rsimha
reviewed
Aug 28, 2019
.travis.yml
Outdated
| # do not store cache for PR builds | ||
| - if [[ $TRAVIS_PULL_REQUEST ]]; then exit $TRAVIS_TEST_RESULT ; fi | ||
| # do not store cache for non-push builds | ||
| - if [[ $TRAVIS_EVENT_TYPE != push ]]; then exit $TRAVIS_TEST_RESULT ; fi |
There was a problem hiding this comment.
Travis conditionals might work too. See https://docs.travis-ci.com/user/conditions-v1
before_cache:
# do not store cache for pull request builds
- exit $TRAVIS_TEST_RESULT
if: type = pull_requestThere was a problem hiding this comment.
Hmm a build wouldn't start with this, seems like invalid config.
|
Ahem... PTAL 🤗 |
rsimha
approved these changes
Aug 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.