🐛 amp-animation scrolltimeline: bug fixes #20915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aghassemi
commented
Feb 20, 2019
zhouyx
suggested changes
Feb 20, 2019
alanorozco
approved these changes
Feb 20, 2019
extensions/amp-animation/0.1/runners/scrolltimeline-worklet-runner.js
Outdated
Show resolved
Hide resolved
|
@zhouyx done. PTAL (merge blocked) |
zhouyx
approved these changes
Feb 25, 2019
|
Sorry for the delay. was concerned about |
noranazmy
pushed a commit
to noranazmy/amphtml
that referenced
this pull request
Mar 22, 2019
bramanudom
pushed a commit
to bramanudom/amphtml
that referenced
this pull request
Mar 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Mostly bug fixes by utilizing the existing calculations done in amp-position-observer and using the new
start/endScrollOffsetproperties ofScrollTimeline.Remaining known bugs
fill:bothpresent onScrollTimeline. Following up with Chrome folks.heightchange behaves differently in worklet vs non-worklet case.Code diff is
+130 −130Adding exactly 0 value :)