Add visual test for sticky-ad #16829
Conversation
test/visual-diff/visual-tests
Outdated
| { | ||
| "url": "examples/visual-tests/amp-sticky-ad/amp-sticky-ad-wrapper.html", | ||
| "name": "AMP Sticky Ad", | ||
| "loading_complete_css": ["ready-for-visual-diff"] |
There was a problem hiding this comment.
I believe this would not work, because the page that gets tested is the wrapper, and the browser will be looking for the CSS class in that page, not inside the iframe. How about sending a message from inside the iframe to the container document, and have the container document add the ready-for-visual-diff class to the iframe on message receipt?
nit: it should be .ready-for-visual-diff, i.e. preceded by a dot
There was a problem hiding this comment.
Ah! Good point! Switched to postMessage.
test/visual-diff/visual-tests
Outdated
| @@ -423,10 +428,6 @@ | |||
| "url": "examples/visual-tests/amp-by-example/components/amp-springboard-player/index.html", | |||
| "name": "amp-springboard-player - Amp By Example" | |||
| }, | |||
| { | |||
There was a problem hiding this comment.
eh, leave it in place. It doesn't cost us anything and will be automatically re-added next time I run the ABE-copying script :)
Codecov Report
@@ Coverage Diff @@
## master #16829 +/- ##
==========================================
- Coverage 78.05% 77.14% -0.92%
==========================================
Files 558 559 +1
Lines 40443 40508 +65
==========================================
- Hits 31569 31249 -320
- Misses 8874 9259 +385
Continue to review full report at Codecov.
|
zhouyx
force-pushed
the
sticky-visual-test
branch
from
e09ce42 to
344964d
Compare
|
Blocked and close for now |
For #11425