Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix accordion specificity #10225

Merged
merged 1 commit into from
Jun 30, 2017
Merged

Fix accordion specificity #10225

merged 1 commit into from
Jun 30, 2017

Conversation

camelburrito
Copy link
Contributor

Fixes #10224

@muxin
Copy link
Contributor

muxin commented Jun 30, 2017

having

amp-accordion > section > :last-child {
  display: none !important;
}
amp-accordion > section[expanded] > :last-child {
  display: block !important;
}

instead of

amp-accordion > section > .i-amphtml-accordion-content {		
  display: none !important;		
}		
amp-accordion > section[expanded] > .i-amphtml-accordion-content {		
  display: block !important;		
}

is ok?

@camelburrito
Copy link
Contributor Author

@muxin - yes that is ok since they have the same specificity

@muxin muxin merged commit af68f81 into ampproject:master Jun 30, 2017
muxin pushed a commit that referenced this pull request Jul 1, 2017
@cramforce
Copy link
Member

Thanks for the quick fix. Is there a way to revert this? The previous state was better (modulo bad specificity) because it didn't FOUCed when the extension loaded late.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants