TypeError: Cannot read property 'origin' of undefined

[zhouyx]

From: https://github.com/ampproject/amphtml/blob/master/src/url.js#L314

Request
https://huntsongs-com.cdn.ampproject.org/v/huntsongs.com/video/ishq-karoge-to-dard-milega-video-song-ekka-raja-rani-govinda-ayesha-julka-kumar-sanu-alka-yagnik-udit-narayan-2437?pg=amp&amp_js_v=0.1
Referrer
https://www.google.co.in/
User agent
Mozilla/5.0 (Linux; Android 5.0.2; vivo Y51L Build/LRX22G; wv) AppleWebKit/537.36 (KHTML, like Gecko) Version/4.0 Chrome/54.0.2840.68 Mobile Safari/537.36 Mobile UCBrowser/3.4.3.532
TypeError: Cannot read property 'origin' of undefined
at Ya (https://cdn.ampproject.org/rtv/021496877433269/v0.js:18:79)
at $a (https://cdn.ampproject.org/rtv/021496877433269/v0.js:19:49)
at $g.get (https://cdn.ampproject.org/rtv/021496877433269/v0.js:225:378)
at id (https://cdn.ampproject.org/rtv/021496877433269/v0.js:62:466)
at Le.Z (https://cdn.ampproject.org/rtv/021496877433269/v0.js:97:455)
at https://cdn.ampproject.org/rtv/021496877433269/v0.js:105:350
at String.replace (native)
at Se (https://cdn.ampproject.org/rtv/021496877433269/v0.js:105:54)
at Re.f.expandUrlAsync (https://cdn.ampproject.org/rtv/021496877433269/v0.js: 100:361)

[jridgewell]

The cause is because

amphtml/src/service/document-info-impl.js

Line 70 in 97649ad

const url = ampdoc.getUrl();

(the $g.get call in the trace) is somehow returning undefined.

[jridgewell]

This is definitely coming from Shadow Docs by way of

amphtml/src/runtime.js

Line 576 in f4d6c33

attachShadowDoc_(hostElement, url, initParams, builder) {

. Since this method is exposed externally, it probably mean someone has implemented their PWA badly.

/to @choumx to add assertions.

[ampprojectbot]

This issue hasn't been updated in awhile. @zhouyx Do you have any updates?

[ampprojectbot]

This issue hasn't been updated in awhile. @choumx Do you have any updates?

[ampprojectbot]

This issue hasn't been updated in awhile. Do you have any updates?

[ampprojectbot]

This issue hasn't been updated in awhile. Do you have any updates?

[kevinkimball]

This happens when you forget to pass the third argument (url) to attachShadowDoc

[kevinkimball]

@choumx did you have something in mind you wanted to do about this, e.g. logging a warning or preventing error reporting? Otherwise I am inclined to close this issue.

[dreamofabear]

Hm, could we verify the arguments to attachShadowDoc and fire a "user" error (which are heavily throttled in reporting)?