Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INTENT TO IMPLEMENT: amp-video-interface API: integration with 3rd party video player Connatix #39374

Open
jimgaop1 opened this issue Aug 15, 2023 · 11 comments
Assignees
Labels
Component: amp-video & interface amp-video and video interface/manager Component: amp-video-docking INTENT TO IMPLEMENT Proposes implementation of a significant new feature. https://bit.ly/amp-contribute-code P3: When Possible Type: Feature Request WG: components

Comments

@jimgaop1
Copy link

Hi – I’m Jimmy from Connatix and we are a video player company for publishers. We have an amp player built with amp components and would love to use the amp-video-docking functionality, which notes being a “supported video player” as a pre-requisite. What is the process of integrating with this amp-video-interface API (i.e., be certified by amp)? Thanks

@jimgaop1
Copy link
Author

@erwinmombay following up to see if someone from AMP could address our question above? thanks a lot

@erwinmombay
Copy link
Member

heya @jimgaop1 , I believe you just need to create an Intent to Implement, get a go ahead from AMP developers and implement the Interface. In this case, we can turn this Issue into an I2I (Intent to Implement)

if you need any help I believe old PR submissions from the other video integration providers can help.

@jimgaop1
Copy link
Author

jimgaop1 commented Aug 23, 2023

@erwinmombay thank you for your reply. could you pls turn this issue into I2I? We do have an AMP video player built out and
our dev team did some research and said that "to integrate with the VideoInterface, we need to send the video player events (e.g., play/pause, mute/unmute, fullscreen) to our own amp-embeded-html.

  1. In terms of progress, how do we get a go-ahead from AMP developers before implementing the video interface?
  2. Would this be the right way to implement the video interface?
    Thanks

@erwinmombay
Copy link
Member

@jimgaop1 thanks for the info. Let me share this issue with the team for input, but i don't see any reason why we wouldnt accept this contribution.

for item number 2, what do you mean by amp-embeded-html ? appreciate any clarification

@erwinmombay erwinmombay reopened this Aug 23, 2023
@jimgaop1
Copy link
Author

@erwinmombay thanks a lot. Please keep us updated.
For item 2, plase don't worry about amp-embeded-html as it refers to our code to set up amp player and get query parameters.

@erwinmombay
Copy link
Member

sounds good. i say go ahead with the implementation. I don't see any reason why we wouldn't accept y'alls contribution

@erwinmombay erwinmombay added the INTENT TO IMPLEMENT Proposes implementation of a significant new feature. https://bit.ly/amp-contribute-code label Aug 23, 2023
@erwinmombay erwinmombay changed the title amp-video-interface API: integration with 3rd party video player Connatix INTENT TO IMPLEMENT: amp-video-interface API: integration with 3rd party video player Connatix Aug 23, 2023
@erwinmombay
Copy link
Member

erwinmombay commented Aug 23, 2023

labeling this as an I2I

@jimgaop1
Copy link
Author

jimgaop1 commented Oct 11, 2023

@erwinmombay hope you are doing well! our dev team at Connatix 9a video player company) is in the final steps of supporting the VideoInterface and adding the amp-video-docking attribute. Both will be ready by next Thursday/Friday.

Questions:

  1. What code and documentation do we need to submit? Is there a guideline for submission?
  2. How long does it take to be approved for being a 3rd party AMP video player?

Thanks for your time and we are eager to hear from you.

@jimgaop1
Copy link
Author

@erwinmombay hope you are doing well. We (Connatix, a video player company) just finished adding video docking support on our amp player.
Could you pls share guidelines on what code and documentation to submit in order for us to appear as a 3rd party video provider on the VideoInterface API and allow users to use the amp-video-docking attribute on the Connatix AMP player? thanks a lot

@erwinmombay erwinmombay self-assigned this Oct 18, 2023
@erwinmombay
Copy link
Member

example of docking implementation:

it looks like from my understanding:

@jimgaop1
Copy link
Author

@erwinmombay our team just submitted the PR review under #39558. Could your team please take a look at this? Thanks a lot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: amp-video & interface amp-video and video interface/manager Component: amp-video-docking INTENT TO IMPLEMENT Proposes implementation of a significant new feature. https://bit.ly/amp-contribute-code P3: When Possible Type: Feature Request WG: components
Projects
None yet
Development

No branches or pull requests

2 participants