Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow TITLE and SOURCE_URL variable substitution in amp-ad RTC urls #38627

Closed
zshnr opened this issue Jan 12, 2023 · 5 comments
Closed

Allow TITLE and SOURCE_URL variable substitution in amp-ad RTC urls #38627

zshnr opened this issue Jan 12, 2023 · 5 comments

Comments

@zshnr
Copy link
Contributor

zshnr commented Jan 12, 2023

Description

Hello,

Would it be possible to add TITLE and SOURCE_URL to the list of allowed macros for RTC config?

If there is no issue with this, I am happy to create a PR to do so :)

Thanks!

Alternatives Considered

We ask our customers to use whatever templating solution they use to do this there. But Ideally we wouldn't want to leave this up to the customer doing the right thing.

Additional Context

These values will be extremely useful to return rich targeting information for our customers that use AMP for their web properties.

@erwinmombay
Copy link
Member

@powerivq @calebcordry could y'all evaluate if there are no issues with adding these?

@calebcordry
Copy link
Member

These seem safe to me, @powerivq any concern?

@powerivq
Copy link
Contributor

I don't see problems with these.

@zshnr
Copy link
Contributor Author

zshnr commented Jan 20, 2023

Thank you all so much! I'll create a PR in that case

@erwinmombay
Copy link
Member

Closed by #38723

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants