Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

amp-story-shopping validation is performed on non-existent shopping tags #38076

Open
jshamble opened this issue Apr 11, 2022 · 0 comments
Open

Comments

@jshamble
Copy link
Contributor

jshamble commented Apr 11, 2022

Description

Validation is performed per tag, regardless if the tag's product id exists or not.
We can do an early exit check even before validation by checking if the tag's product id actually exists within the dom.

Reproduction Steps

Load any config with a tag with a productId that doesn't exist in the DOM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants